Screenshot cache contains many large files

[low-batt]

System and IINA version:

• macOS 14.4.1
• IINA 1.3.4

Expected behavior:
Disk caches are bounded in size.

Actual behavior:
@hugepower reports in this comment:

I am using PNG format for my screenshots, and each one occupies approximately 2MB of space. Surprisingly, in the ~/Library/Caches/com.colliderli.iina/screenshot_cache directory, IINA has stored nearly 10GB of past screenshot images. I am puzzled by this as I don't understand the need to retain so many screenshots, which seem to be taking up a significant amount of unnecessary storage space.

Steps to reproduce:

• Start IINA

• Click on Settings… under the IINA menu

• The settings panel appears

• Scroll down to the Screenshots section

• Uncheck the Save to setting

• Uncheck the Show previews after taking screenshots

• Start playing a video

• Take a screenshot

• Notice a file still remains in the ~/Library/Caches/com.colliderli.iina/screenshot_cache directory

• MPV does not have this problem.

How often does this happen?
Every time with the settings shown above.

[hugepower]

System and IINA version:

macOS Sonoma 14.4.1
IINA 1.3.4

In IINA's screenshot settings, when only the "Copy to Clipboard" function is enabled, each screenshot taken will be automatically saved to the designated directory.

[low-batt]

Reproduced for me. This is a defect.

When the Save to screenshot setting is disabled IINA uses the ~/Library/Caches/com.colliderli.iina/screenshot_cache cache directory. That is expected. The defect is that the code that removes the temporary file is not executed if the Show previews after taking screenshots setting is disabled.

At least that is my analysis after a quick investigation. Do you have Show previews after taking screenshots unchecked?

[hugepower]

Reproduced for me. This is a defect.

When the Save to screenshot setting is disabled IINA uses the ~/Library/Caches/com.colliderli.iina/screenshot_cache cache directory. That is expected. The defect is that the code that removes the temporary file is not executed if the Show previews after taking screenshots setting is disabled.

At least that is my analysis after a quick investigation. Do you have Show previews after taking screenshots unchecked?

Yes. I did not enable this feature.

[low-batt]

Thank you so much for reporting this problem and providing the additional information. I was initially confused by this report as I didn't know IINA had a screenshot cache. Wasting disk space is a critical problem that must be fixed. I have added this issue as a high priority fix for the next release.