Fix audio delay units uses two lines in Hebrew, #4895 #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Moved this to be a draft due to the problem being discussed in the issue. |
low-batt
force-pushed
the
he-audio-delay
branch
from
58fe0ac
to
a85c300
Compare
This commit will: - Change the Line Break attribute of the text field holding the units from Word Wrap to Clip - Add a width constraint to the text field displaying slider setting as a numeric value - Change the width constraint of the similar text field on the SUBTITLES tab to match the new constraint added to the AUDIO tab This prevents the audio delay units field from wrapping into two lines and places a limit on the minimum size of the text field displaying the slider value such that the number it holds is not truncated when the user reduces the window size so much that the quick settings panel is compressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix audio delay units uses two lines in Hebrew, #4895
This commit will:
Line Breakattribute of the text field holding the units fromWord WraptoClipSUBTITLEStab to match the new constraint added to theAUDIOtabThis prevents the audio delay units field from wrapping into two lines and places a limit on the minimum size of the text field displaying the slider value such that the number it holds is not truncated when the user reduces the window size so much that the quick settings panel is compressed.
Description: