You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior:
Filter names are not truncated.
Actual behavior:
PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then the filter name for a custom FFmpeg filter is truncated in the sheet for adding a filter:
The table of filters should be automatically resized to adapt to the size of the filter names in other languages.
NOTE that this problem can also be reproduced using the develop branch and English. In Xcode open FilterWindowController.xib. Built and run IINA. The Custom (FFmpeg) filter name is now truncated:
Digging through all the changes to the XIB Xcode helpfully adds even if you only open the file in the editor and don't make any changes I see:
There are warning in the build log regarding layout problems:
/* com.apple.ibtool.document.notices */
/Users/low-batt/Documents/builds/iina-official/iina/iina/Base.lproj/FilterWindowController.xib:MAd-sY-Hvg: note: NSTextField's height does not match its intrinsic content size, use "Size to Fit Content" to correct [22]
/Users/low-batt/Documents/builds/iina-official/iina/iina/Base.lproj/FilterWindowController.xib:cLl-pZ-KNW: note: View is clipping its content [13]
/Users/low-batt/Documents/builds/iina-official/iina/iina/Base.lproj/FilterWindowController.xib:ZJo-ef-lfp: note: View is clipping its content [13]
/Users/low-batt/Documents/builds/iina-official/iina/iina/Base.lproj/FilterWindowController.xib:56K-2H-lTw: note: View is clipping its content [13]
This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this particular problem.
@low-batt Sure. Funny, I just refactored this dialog on my fork. I needed to rework most of the layout just to get the window to resize sanely. Should be straightforward to cut a PR.
System and IINA version:
Expected behavior:
Filter names are not truncated.
Actual behavior:
PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then the filter name for a custom FFmpeg filter is truncated in the sheet for adding a filter:
The table of filters should be automatically resized to adapt to the size of the filter names in other languages.
NOTE that this problem can also be reproduced using the
develop
branch and English. In Xcode openFilterWindowController.xib
. Built and run IINA. TheCustom (FFmpeg)
filter name is now truncated:Digging through all the changes to the XIB Xcode helpfully adds even if you only open the file in the editor and don't make any changes I see:
Xcode is messing with the width of table columns.
There are warning in the build log regarding layout problems:
This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this particular problem.
Steps to reproduce:
Pull PR feat: enable hebrew locale #4922
Open the IINA project in Xcode
Under the
Product
menu open theScheme
menu and selectEdit Scheme…
Click on the
Options
tabScroll down to the
App Language
settingIn the pull down select
Hebrew
Start IINA running under Xcode
Click on
Video Filters…
under theVideo
menuThe
Video Filters
window appearsClick on the
+
buttonThe sheet for adding a filter appears
Notice the last filter in the list is truncated
MPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: