Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtitles override level not localized, #4892 #4893

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix subtitles override level not localized, #4892 #4893

wants to merge 1 commit into from

Conversation

low-batt
Copy link
Contributor

This commit will:

  • Add key-value pairs for the yes, force and strip override levels to the base and en Localizable.strings files
  • Change the transformedValue method in the ASSOverrideLevelTransformer class to return a localized string instead of the enum value string

This localizes the value displayed for the Override level setting found in the ASS Subtitles section on the Subtitle tab in IINA's settings.

Description:

@low-batt
Fix subtitles override level not localized, #4892
006d0e0 
This commit will:
- Add key-value pairs for the yes, force and strip override levels to
  the base and en Localizable.strings files
- Change the transformedValue method in the ASSOverrideLevelTransformer
  class to return a localized string instead of the enum value string

This localizes the value displayed for the Override level setting found
in the ASS Subtitles section on the Subtitle tab in IINA's settings.
@low-batt low-batt linked an issue Apr 26, 2024 that may be closed by this pull request
Subtitles override level not localized #4892
Open
1 task
@low-batt
Copy link
Contributor Author

One issue I did not address is that the text field holding the label is being sent to translators even though that value will never be used. Run this command to see the translations:

grep -inr --include \*.strings 3H8-Ei-cTm *

I did not find a way in Xcode to exclude this text field from localization. Did I miss something?

Because Crowdin is not able to read an XIB file as discussed in #4468 we have to use the English strings file. Would deleting the entry for the object ID 3H8-Ei-cTm from the English translations remove this translation from Crowdin?

Searching the net I found people using various methods, for example a reply to the stack overflow post Marking some XIB/Storyboard strings as not localizable suggests using as special phrase in the Localizer Hint XIB field and then using XMLStarlet to detect and delete elements from the XLIFF.

We might want to have some sort of Localizer Hint convention even when relying upon not putting the object ID into the English strings file to make it clear that a particular object should not be localized.

@low-batt low-batt requested a review from uiryuu April 26, 2024 03:54
@low-batt low-batt mentioned this pull request Apr 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiryuu uiryuu Awaiting requested review from uiryuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtitles override level not localized
1 participant
@low-batt