Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ticks" on the timeline when A-B looping an audio file #4880

Open
orbited303 opened this issue Apr 15, 2024 · 1 comment
Open

"Ticks" on the timeline when A-B looping an audio file #4880

orbited303 opened this issue Apr 15, 2024 · 1 comment

Comments

@orbited303
Copy link

System and IINA version:

  • macOS 14.4.1 (23E224)
  • IINA 1.3.4

Expected behavior:
When setting an A-B loop in an audio file (mp3, m4a etc) I expect "ticks" on the timeline to indicate the loop points (as it does when playing video files).

Actual behavior:
The file loops without issue, but loop points are not indicated on the timeline.

Steps to reproduce:

  1. Open an audio file in IINA.
  2. Press CMD-L to set A point, press CMD-L to set B point. (Or use menus!)
  3. Ticks are not present.

How often does this happen?
Every time.

@low-batt
Copy link
Contributor

In Apple's Slider terminology "tick marks" are defined like so:

Sliders in macOS can also include tick marks, making it easier for people to pinpoint a specific value within the range.

If IINA's Show chapter position in progress bar is enabled and the media has chapters then tick marks will be used to show the chapter position. You have to look closely as they are small and faint.

The marks that appear in the main window's on screen controller's slider when A-B loop points are active look like tick marks and indeed match the above definition of pinpointing a value, but they are not tick marks. In Apple's public terminology they are "thumbs". In Apple's developer documentation for NSSlider they are referred to as "knobs". These additional thumbs can be moved just like the the primary thumb that controls the playback position. They are harder to grab when the primary thumb is near them as IINA will prefer the primary thumb over the loop thumbs, so you may need to first move the primary thumb out of the way to be able to grab and move one of the loop thumbs. These loop thumbs can be used to dynamically modify the A-B loop points. The macOS slider does not support multiple thumbs. IINA extended NSSlider to add this feature.

This is the first time anyone has mentioned the A-B loop thumbs since they were added. I wasn't sure users cared about this feature.

The small player window does not show the A-B loop points as it has not been implemented for that window's slider. I wanted to first get this feature implemented and released for the main window. I also had some concerns about how well these thumbs would work in the smaller slider the small window has.

I will investigate what it takes to add this to the music mode player window. It might be easy to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants