-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cut/separator tests #2536
Comments
Can I work on this? Im looking to contribute to an open source project for the first time. |
Yes, you are also welcome to work on this! Before getting started, make sure that you are able to compile a simple test program yourself, see https://igraph.org/c/doc/igraph-Tutorial.html to get started (see https://igraph.org/c/doc/igraph-Installation.html for how to install the development version of One you've passed those first hurdles, try to see if you can create a small program according to the specifications above. Once you've got something running, it would be good to open a (draf) PR. Once it all works as expected we can integrate it properly into igraph as a test, I'll help you on your way there. |
We need tests that double check cut results. In particular, tests should check (1) whether a cut is indeed an incorrect cut (i.e. after removing the proposed edges/vertices in the cut/separators, we should double check the connectivity); and (2) for minimal cuts, we should check whether they are indeed minimal.
In particular, the graphs listed in #2532 could be tested for cuts, while the graphs listed in #2521 could be used for separators.
One could use
igraph_distances
to check whether there is a path still between two specific nodes. So, the core of the test could be something like the following for cuts (and something similar for separators).The text was updated successfully, but these errors were encountered: