Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop a folder to ILSpy? #3171

Closed
aybe opened this issue Mar 5, 2024 · 1 comment
Closed

Drag and drop a folder to ILSpy? #3171

aybe opened this issue Mar 5, 2024 · 1 comment
Labels
Enhancement Areas for improvement

Comments

@aybe
Copy link

aybe commented Mar 5, 2024

Is your feature request related to a problem? Please describe.

Tried to drop a folder in the application, hoping it would load all DLLs in it but got the following instead:

System.UnauthorizedAccessException: Access to the path 'C:\Program Files\paint.net' is denied.
   at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access)
   at ICSharpCode.ILSpyX.LoadedAssembly.LoadAsync(Task`1 streamTask) in /_/ICSharpCode.ILSpyX/LoadedAssembly.cs:line 340
   at ICSharpCode.ILSpy.TreeNodes.AssemblyTreeNode.Decompile(Language language, ITextOutput output, DecompilationOptions options)
   at ICSharpCode.ILSpy.TextView.DecompilerTextView.DecompileNodes(DecompilationContext context, ITextOutput textOutput)
   at ICSharpCode.ILSpy.TextView.DecompilerTextView.<>c__DisplayClass53_0.<DecompileAsync>b__0()

Basically, it mistook it as an assembly.

Describe the solution you'd like

Maybe the software could handle such scenario?

That is, to load every DLL in the folder that's been dropped.

Additional context

image

@aybe aybe added the Enhancement Areas for improvement label Mar 5, 2024
@christophwille
Copy link
Member

christophwille commented Jul 22, 2024

This most likely won't make it - because you could go inside that folder, select the assemblies in question, and drag and drop those onto ILSpy:
image
Supporting folders would mean all sorts of smarts - like ignoring anything not being an assembly, and what is the expected behavior with subfolders of that folder? Include, or only grab assemblies from the dragged "parent" folder?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Areas for improvement
Projects
None yet
Development

No branches or pull requests

2 participants