Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] v2: Migrate ECS back-end to Harmony, drop Python <=3.9, & other breaking changes #544

Closed
wants to merge 1 commit into from
Closed

[WIP] v2: Migrate ECS back-end to Harmony, drop Python <=3.9, & other breaking changes #544

wants to merge 1 commit into from

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Aug 8, 2024 •
edited by JessicaS11
Loading

Closes #530

ECS is being decommissioned. To enable icepyx to continue working, we'll release a v2 which uses Harmony as the back-end. v1 will cease to function. We will add a deprecation warning to v1 on an upcoming release.

Breaking changes

  • Remove support for variable subsetting
  • ?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Binder 👈 Launch a binder notebook on this branch for commit 16f8c69

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 4e7af20

Binder 👈 Launch a binder notebook on this branch for commit a7bba90

Binder 👈 Launch a binder notebook on this branch for commit 498b0c8

Binder 👈 Launch a binder notebook on this branch for commit 3600a7b

Binder 👈 Launch a binder notebook on this branch for commit 07c0d90

Binder 👈 Launch a binder notebook on this branch for commit 35eafe0

Binder 👈 Launch a binder notebook on this branch for commit 817175b

@mfisher87 mfisher87 changed the title v2 v2: Migrate ECS back-end to Harmony Aug 8, 2024
@mfisher87 mfisher87 mentioned this pull request Aug 8, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.37%. Comparing base (a762ad8) to head (817175b).
Report is 30 commits behind head on development.

Additional details and impacted files 
@@             Coverage Diff              @@
##           development     #544   +/-   ##
============================================
  Coverage        65.37%   65.37%           
============================================
  Files               36       36           
  Lines             3038     3038           
  Branches           531      531           
============================================
  Hits              1986     1986           
  Misses             970      970           
  Partials            82       82

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfisher87 mfisher87 mentioned this pull request Aug 8, 2024
Merged
@mfisher87 mfisher87 force-pushed the v2 branch 3 times, most recently from a7bba90 to 498b0c8 Compare August 12, 2024 23:58
@mfisher87 mfisher87 changed the title v2: Migrate ECS back-end to Harmony [WIP] v2: Migrate ECS back-end to Harmony Aug 13, 2024
@mfisher87 mfisher87 force-pushed the v2 branch 2 times, most recently from 3600a7b to 07c0d90 Compare August 14, 2024 22:45
@mfisher87 mfisher87 changed the title [WIP] v2: Migrate ECS back-end to Harmony [WIP] v2: Migrate ECS back-end to Harmony, drop Python <=3.9, & other breaking changes Aug 21, 2024
@JessicaS11
Copy link
Member

Should we close this in favor of #613?

@mfisher87
Copy link
Member Author

Yes, good call. This is a vestige of when we planned on working on a v2 branch.

@mfisher87 mfisher87 closed this Sep 26, 2024
@mfisher87 mfisher87 deleted the v2 branch September 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transition to Harmony API from on-prem EGI
2 participants
@mfisher87 @JessicaS11