Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for macOS broken since ImGuiFileDialog also broken for macOS #85

Open
gerald24 opened this issue Aug 21, 2022 · 5 comments
Open

Comments

@gerald24
Copy link

Since 15 Feb 2022 build for ImGuiFileDialog is broken for macOS

Screenshot 2022-08-21 at 08 52 10

after changing build.gradle.kts line 147 to 162, so that commits from 20 Jan are used:

  • commit 87cd5def54ac0cc2952df63d98a8dbbae714e88d for master
  • commit ce5edcbf10748292609f971372d7b8e64230e97b for branch Lib_Only

the build succeeded successful.

val downloadDirent = tasks.register<Download>("downloadDirent") {
  src("$imguiFD/ce5edcbf10748292609f971372d7b8e64230e97b/dirent/dirent.h")
  dest(fdDir.resolve("dirent").resolve("dirent.h"))
  overwrite(false)
}

val downloadFileDialog = tasks.register<Download>("downloadFileDialog") {
  group = downloadGroup
  if (isWindows) dependsOn(downloadDirent)
  src("$imguiFD/87cd5def54ac0cc2952df63d98a8dbbae714e88d/CustomFont.h")
  src("$imguiFD/87cd5def54ac0cc2952df63d98a8dbbae714e88d/CustomFont.cpp")
  src("$imguiFD/ce5edcbf10748292609f971372d7b8e64230e97b/ImGuiFileDialog.h")
  src("$imguiFD/ce5edcbf10748292609f971372d7b8e64230e97b/ImGuiFileDialog.cpp")
  dest(fdDir)
  overwrite(false)
}

Environment:

Gradle 7.4.1
Kotlin:       1.5.31
Groovy:       3.0.9
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          17.0.2 (Oracle Corporation 17.0.2+8-86)
OS:           Mac OS X 12.5.1 aarch64

cmake version 3.24.1
glfw: stable 3.3.8
@ice1000
Copy link
Owner

ice1000 commented Aug 21, 2022

I am expecting imfiledialog's failure to build on macos to be a bug of theirs. I think they should fix it and we follow up.

I'm not making any releases lately, so using the latest release version should be fine.

Or do you have to build jimgui yourself?

@gerald24
Copy link
Author

gerald24 commented Aug 21, 2022

I don't expect it to be fixed in jimgui. I just wanted to point it out in case anyone else has the problem.

Btw. thanks for jimgui :-)

@ice1000
Copy link
Owner

ice1000 commented Aug 21, 2022

I don't expect it to be fixed in jimgui. I just wanted to point it out in case anyone else has the problem.

Btw. thanks for jimgui :-)

With project panama I hope we won't need binding libraries anymore. RIP jimgui.

@ice1000
Copy link
Owner

ice1000 commented Aug 21, 2022

And btw, you're welcome :-)

@aiekick
Copy link

aiekick commented Sep 13, 2022

Hello,

the issue i have as i know about macos is just related to github actions. i not found a proper way for it.

if imgui is working and even you have dirent.h or using std::filessytem for c++17, there is no well known issue about macos,
as you can see all errors are related to imgui, so jsut a bad configuration for macos it seems. maybe just a version of gcc + libs as usual with mac..
https://github.com/aiekick/ImGuiFileDialog/actions/runs/2538776825/jobs/3898093386

but if you have some feedback, plase share :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants