Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate newest imgui to here #27

Closed
ice1000 opened this issue Mar 4, 2019 · 34 comments
Closed

Migrate newest imgui to here #27

ice1000 opened this issue Mar 4, 2019 · 34 comments
Assignees
@ice1000

Comments

@ice1000
Copy link
Owner

ice1000 commented Mar 4, 2019

No description provided.

@ice1000 ice1000 self-assigned this Mar 4, 2019
@Mr00Anderson
Copy link
Contributor

Mr00Anderson commented May 30, 2019 •
edited
Loading

Are Tabs apart of this update?
Tabs - ImGui

@ice1000
Copy link
Owner Author

ice1000 commented May 30, 2019

I did not continue developing this because I don't have a Mac thus cannot build a dylib with it

@ice1000
Copy link
Owner Author

ice1000 commented May 30, 2019

Are Tabs apart of this update?
Tabs - ImGui

It's supposed to be added easily

@Mr00Anderson
Copy link
Contributor

Mr00Anderson commented May 30, 2019 •
edited
Loading

Would procuring a cloud solution for the mac be useful? Microsoft offers free mac agents and its free for open source. I use the mac ones since I have yet to procure a Mac myself. I could add the tabs to the code base then. Not familiar with this project build scripts yet, so might take me some time to get it complete.

My current solution is just using a horizontal single selection for now.

@ice1000
Copy link
Owner Author

ice1000 commented May 30, 2019

Would procuring a cloud solution for the mac be useful? Microsoft offers free mac agents and its free for open source. I use the mac ones since I have yet to procure a Mac myself. I could add the tabs to the code base then. Not familiar with this project build scripts yet, so might take me some time to get it complete.

Could u help me? I've just tried to revive this project, bumping the dependent toolchains to the most (or second-most) recent versions, use the official imgui sources (instead of my own fork, which has some private additions but very old), and the build script works.

@ice1000
Copy link
Owner Author

ice1000 commented May 30, 2019

To build, ./gradlew build on mac and you can find a libjimgui.dylib file in the res directory.

Currently there are some trivial compilation errors due to API changes, working on fixing them

@Mr00Anderson
Copy link
Contributor

https://dev.azure.com/mr00anderson/JImGui
For now working on setting up the build pipelines now. Well see what happens.

@Mr00Anderson
Copy link
Contributor

Mr00Anderson commented May 31, 2019 •
edited
Loading

Ill try to get this working tonight on my windows and then windows pipeline on devops azure. After that Ill work on mac and linux.

@Mr00Anderson
Copy link
Contributor

So you want to pull the files directly from the ImGui repo?

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

So you want to pull the files directly from the ImGui repo?

You don't need to do so, the build script will download the minimum required files for you.
Just run ./gradlew build with:

  • CMake at least 3.12 (sorry for this. Because I need VS 16 2019 on Windows, which requires the most recent release)
  • JAVA_HOME configured properly

@Mr00Anderson
Copy link
Contributor

I thought above you were asking to have me use the official sources. Ooooh I understand now. Yes I always use the source library first, most of the stuff in my editor I used from the c++ and just guessed where it was in JImGui.

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

Because this project is not maintained for a while. Now it's revived

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

Recent commits are building successfully, working on coaxing CIs and new APIs

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

Tab APIs are added

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

Can anyone build a mac dylib for me please

@Mr00Anderson
Copy link
Contributor

I am working on it, trying to with DevOps Azure. Might be a day or two.

@Mr00Anderson
Copy link
Contributor

Mr00Anderson commented May 31, 2019 •
edited
Loading

I am stuck messing with the Build Agents Java for some reason doesn't come with JavaFX. I am working on setting up a custom JDK on the agent so that it can build.

@owo-bot
Copy link

owo-bot commented May 31, 2019

No need JavaFX. Did you forget pulling the repo? I'm updating it from time to time.

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

Tested on Windows and Linux

@Mr00Anderson
Copy link
Contributor

There is some code that uses JavaFX
image

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

They're removed: 2d508e2

@ice1000
Copy link
Owner Author

ice1000 commented May 31, 2019

Btw, now I required CMake 3.14 because of Visual Studio 2019 only. If you're building it with MacOS (thus no Visual Studio), you can manually edit the CMakeLists.txt to downgrade the dependent CMake version to 3.5 and use a lower version

@Mr00Anderson
Copy link
Contributor

I got the pipeline working with the agent dependencies. Just having issues with some test? I am using the most recent commit.

Download https://pic4.zhimg.com/61984a25d44df15b857475e7f7b1c7e3_xl.jpg
> Task :core:downloadIce1000
> Task :core:processTestResources
> Task :core:testClasses

> Task :core:test FAILED
Resolved org.jetbrains:annotations:16.0.1 in :core:testRuntimeClasspath 
Resolved junit:junit:4.12 in :core:testRuntimeClasspath 
2019-06-01 00:06:20.878 java[1398:7846] WARNING: nextEventMatchingMask should only be called from the Main Thread! This will throw an exception in the future.
2019-06-01 00:06:20.878 java[1398:7846] *** Assertion failure in +[NSUndoManager _endTopLevelGroupings], /BuildRoot/Library/Caches/com.apple.xbs/Sources/Foundation/Foundation-1575.12/Foundation/Misc.subproj/NSUndoManager.m:361
2019-06-01 00:06:20.879 java[1398:7846] *** Assertion failure in +[NSUndoManager _endTopLevelGroupings], /BuildRoot/Library/Caches/com.apple.xbs/Sources/Foundation/Foundation-1575.12/Foundation/Misc.subproj/NSUndoManager.m:361
2019-06-01 00:06:20.883 java[1398:7846] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '+[NSUndoManager(NSInternal) _endTopLevelGroupings] is only safe to invoke on the main thread.'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff35140e39 __exceptionPreprocess + 256
	1   libobjc.A.dylib                     0x00007fff5f88d3c6 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff3515be3e +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x00007fff37418c85 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
	4   Foundation                          0x00007fff3734bcfa +[NSUndoManager(NSPrivate) _endTopLevelGroupings] + 473
	5   AppKit                              0x00007fff326fb915 -[NSApplication run] + 916
	6   libglfw.3.dylib                     0x0000000114753804 _glfwPlatformCreateWindow + 81
	7   libglfw.3.dylib                     0x000000011474e533 glfwCreateWindow + 460
	8   libjimgui.dylib                     0x0000000114a0ba6c Java_org_ice1000_jimgui_JImGui_allocateNativeObjects + 188
	9   ???                                 0x0000000114bde3a7 0x0 + 4642956199
	10  ???                                 0x0000000114bcdb10 0x0 + 4642888464
	11  ???                                 0x0000000114bcdffd 0x0 + 4642889725
	12  ???                                 0x0000000114bcdffd 0x0 + 4642889725
)
libc++abi.dylib: terminating with uncaught exception of type NSException

FAILURE: Build failed with an exception.

@ice1000
Copy link
Owner Author

ice1000 commented Jun 1, 2019

I got the pipeline working with the agent dependencies. Just having issues with some test? I am using the most recent commit.

Don't worry, it's because something mentioned in README (about a JVM argument).
Could you please upload /core/res/native/libjimgui.dylib to this thread?

@Mr00Anderson
Copy link
Contributor

Mr00Anderson commented Jun 1, 2019 •
edited
Loading

@ice1000 I have attached it.

Download URL

libjimgui.zip

@ice1000
Copy link
Owner Author

ice1000 commented Jun 1, 2019

Thanks

@ice1000
Copy link
Owner Author

ice1000 commented Jun 2, 2019

Released 0.8 on bintray. Enjoy your tabs.

Tested on Ubuntu Linux 18.04, works like a charm.

@ice1000 ice1000 closed this as completed Jun 2, 2019
@ice1000
Copy link
Owner Author

ice1000 commented Jun 2, 2019

Tested tabs on Windows 10, works like a charm
image

@Mr00Anderson
Copy link
Contributor

image

@ice1000
Copy link
Owner Author

ice1000 commented Jun 3, 2019

FYI u can use a CheckBox for enabled option.

@Mr00Anderson
Copy link
Contributor

FYI u can use a CheckBox for enabled option.

Yea I just have it locked as read only atm.

@ice1000
Copy link
Owner Author

ice1000 commented Jun 3, 2019

@Mr00Anderson Might need your help again -- for #31

@ice1000
Copy link
Owner Author

ice1000 commented Jun 3, 2019

Haven't worked on adding the missing functions here yet, but that's gonna be in close future

@ice1000
Copy link
Owner Author

ice1000 commented Jun 3, 2019

s/close/near/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ice1000 ice1000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mr00Anderson @ice1000 @owo-bot