Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

columns are misaligned depending on module positions top_right or top_left #30

Closed
E3V3A opened this issue May 4, 2018 · 4 comments
Closed
Labels

Comments

@E3V3A
Copy link
Contributor

E3V3A commented May 4, 2018

The columns are misaligned depending if the module position is on left or right side (e.g. top_right or top_left). Ideally there should be a CSS left justification somewhere in the DOM. (And right just for 3rd and last column.)

Also need column space when last seen not enabled/available.
Related to #29

@E3V3A
Copy link
Contributor Author

E3V3A commented May 7, 2018

The best solution is probably to add a CSS file, and make sure we have 3 columns.

ianperrin added a commit that referenced this issue May 8, 2018
@ianperrin
Copy link
Owner

@E3V3A - 1a89250 (on the develop branch) contains an initial fix for the alignment issues. Could you test and confirm it works as expected?

cd ~/MagicMirror/modules/MMM-NetworkScanner
git checkout --track origin/develop

@E3V3A
Copy link
Contributor Author

E3V3A commented May 9, 2018

Great! Yeah, that seem to work! 👍

@ianperrin ianperrin added the bug label May 10, 2018
@ianperrin
Copy link
Owner

Thanks @E3V3A - v0.0.4 has been published - you may want to switch back to the master branch again:

cd ~/MagicMirror/modules/MMM-NetworkScanner
git checkout master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants