New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus metric naming best practices not followed #372

Open

1 of 2 tasks

perkons opened this issue Sep 15, 2023 · 1 comment · May be fixed by #377

perkons commented Sep 15, 2023

I'm submitting a ...

bug report
feature request

What is the current behavior?

The metric name "oracledb_tablespace_free" does not follow the Prometheus naming best practices documented here: https://prometheus.io/docs/practices/naming/

A change would need to be done in the following lines:
https://github.com/iamseth/oracledb_exporter/blob/master/default-metrics.toml#L48
https://github.com/iamseth/oracledb_exporter/blob/master/default-metrics.toml#L55
I am not sure about this line https://github.com/iamseth/oracledb_exporter/blob/master/default-metrics.toml#L17 but it looks like this one too should be "free_bytes"

What is the expected behavior?

Expected metric name would be "oracledb_tablespace_free_bytes"

Collaborator

Yannig commented Oct 29, 2023

Hi,

The name is quite old. If we change it, it will broke existing dashboards.

But you can do a PR if you want to change it.

perkons linked a pull request

that will close this issue

Fix metric name #377

Open

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment