Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search + click on highlighted tag searches by HTML instead of by tag content #917

Open
RamRS opened this issue Oct 20, 2022 · 0 comments
Open

Comments

@RamRS
Copy link

RamRS commented Oct 20, 2022

This happens both at https://www.biostars.org/ and https://support.bioconductor.org/

Steps to reproduce:

  1. Search for a term that can appear in/as tags: https://www.biostars.org/post/search/?query=TCGA
  2. Click on a tag that has a yellow highlight: screenshot
  3. Generates a weird tag query (https://www.biostars.org/tag/%3Cb%20class=%22match%20term0%22%3ETCGA%3C/b%3E/).

This happens because while a non-highlighted tag has the HTML content <a class="ptag" href="/tag/barcode/">barcode</a>, a highlighted tag has the content <a class="ptag" href="/tag/%3Cb%20class=%22match%20term0%22%3ETCGA%3C/b%3E/"><b class="match term0">TCGA</b></a> or the not so clean <a class="ptag" href="/tag/<b class="match term0">TCGA</b>/"><b class="match term0">TCGA</b></a>. It looks like the part that sets the innerHTML for the tag also sets the link in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant