Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve terrain subdivision and raster tiles fecthing #2421

Open
jailln opened this issue Oct 2, 2024 · 1 comment
Open

Improve terrain subdivision and raster tiles fecthing #2421

jailln opened this issue Oct 2, 2024 · 1 comment
Assignees
Labels

Comments

@jailln
Copy link
Contributor

jailln commented Oct 2, 2024

Context

Several bugs are related to terrain subdivision and raster tiles fetching - for instance #2159 ; #2214 and the following behaviour that can sometimes happen (unfortunately I can't share the terrain source for this one for now):

output.mp4

The terrain subdivision code (mostly in TiledGeometryLayer) has become quite complex, is hard to understand (see discussions in #2159 and #2344 for instance) and is buggy (see aforementioned issues).

Proposed Solution

I think we need to:

  • Refactor and simplify this part of the code that has a high cognitive complexity
  • Extract and document the algorithms that control tile subdivision and raster tiles fetching
  • That should eventually facilitate related bug fixing

I've started to work on a refactoring and simplification on this branch

@jailln jailln added the bug 🐛 label Oct 2, 2024
@jailln jailln self-assigned this Oct 2, 2024
@airnez
Copy link
Contributor

airnez commented Oct 17, 2024

Also related to #2442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants