Run eslint -> JavaScript heap out of memory #1883

ximex · 2022-12-13T15:00:08Z

🐛 Bug Report

If i run eslint i got this error since i18next v2.4.4. It comes from the rules "@typescript-eslint/no-misused-promises". I don't know if it is a @typescript-eslint or i18next bug.
With v2.4.3 or before there are no problems.

> eslint ./


<--- Last few GCs --->

[12938:0x67d8210]    77956 ms: Mark-sweep (reduce) 1881.7 (1921.3) -> 1881.7 (1914.3) MB, 950.8 / 0.0 ms  (average mu = 0.564, current mu = 0.000) last resort; GC in old space requested
[12938:0x67d8210]    78893 ms: Mark-sweep (reduce) 1881.7 (1914.3) -> 1881.7 (1914.3) MB, 936.6 / 0.0 ms  (average mu = 0.379, current mu = 0.000) last resort; GC in old space requested


<--- JS stacktrace --->

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: 0xb6e500 node::Abort() [node]
 2: 0xa7e632  [node]
 3: 0xd47f20 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xd482c7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xf137bf v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [node]
 6: 0xef3b80 v8::internal::Factory::AllocateRaw(int, v8::internal::AllocationType, v8::internal::AllocationAlignment) [node]
 7: 0xeeb14c v8::internal::FactoryBase<v8::internal::Factory>::AllocateRawArray(int, v8::internal::AllocationType) [node]
 8: 0xeeb2c5 v8::internal::FactoryBase<v8::internal::Factory>::NewFixedArrayWithFiller(v8::internal::Handle<v8::internal::Map>, int, v8::internal::Handle<v8::internal::Oddball>, v8::internal::AllocationType) [node]
 9: 0x11a493e v8::internal::MaybeHandle<v8::internal::OrderedHashMap> v8::internal::OrderedHashTable<v8::internal::OrderedHashMap, 2>::Allocate<v8::internal::Isolate>(v8::internal::Isolate*, int, v8::internal::AllocationType) [node]
10: 0x11a49f3 v8::internal::MaybeHandle<v8::internal::OrderedHashMap> v8::internal::OrderedHashTable<v8::internal::OrderedHashMap, 2>::Rehash<v8::internal::Isolate>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::OrderedHashMap>, int) [node]
11: 0x12ae96d v8::internal::Runtime_MapGrow(int, unsigned long*, v8::internal::Isolate*) [node]
12: 0x16e99f9  [node]
Aborted (core dumped)

To Reproduce

run eslint with rule "@typescript-eslint/no-misused-promises"

Expected behavior

That eslint runs through again

Your Environment

runtime version: node v18.12.1
i18next version: v2.4.5
os: Linux

The text was updated successfully, but these errors were encountered:

adrai · 2022-12-13T15:01:20Z

Can you please provide a minimal repository so we can reproduce this?

esetnik · 2022-12-14T14:59:42Z

I have confirmed the same issue in my project. Both v2.4.4 and v2.4.5 are affected.

jansedlon · 2022-12-15T17:36:39Z

Mine as well. When I run tsc with version 2.4.5 it crashes with the same error. It runs out of memory. Version 22.4.3 is the latest that works fine

esetnik · 2022-12-20T22:14:23Z

@adrai Same issue on v22.4.6

stale · 2022-12-31T23:20:51Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

esetnik · 2023-01-02T23:01:27Z

Mark as not stale

esetnik · 2023-01-04T04:16:59Z

Still happening on v22.4.8

esetnik · 2023-01-04T04:18:31Z

Is this related to #1857?

stale · 2023-01-17T02:46:06Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ximex · 2023-01-17T09:15:58Z

Mark as not stale

CreativeTechGuy · 2023-01-22T02:42:52Z

Minimal repo is now available here: #1901 @adrai. Hope this helps!

esetnik · 2023-02-17T14:57:46Z

I can confirm this is still occurring on v22.4.10

stale · 2023-03-18T05:30:23Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-04-02T06:31:18Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-05-04T02:13:58Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

adrai · 2023-06-15T09:42:34Z

Please try with i18next v23.0.1 and react-i18next v13.0.0

esetnik · 2023-06-15T15:14:11Z

@adrai see #1972

pedrodurek · 2023-06-22T17:16:19Z

Hey @esetnik, we really need a reproducible example to investigate what should be the root cause 😢

esetnik · 2023-06-22T18:32:13Z

@pedrodurek sorry I have been trying to build a reproducible example but I cannot even get the example I put together to typecheck cleanly due to i18next/react-i18next#1647 so I cannot provide a full example which demonstrates this issue.

adrai · 2023-07-26T05:44:51Z

Can you try if it's better with v23.3.0?

esetnik · 2023-07-26T20:02:42Z

Unfortunately no it's the same issue

adrai · 2023-07-28T16:39:41Z

Unfortunately no it's the same issue

@ximex and for you?

ximex · 2023-08-07T09:44:59Z

"i18next": "^23.4.2",
"react-i18next": "^13.0.3",

with this versions tested it looks like it is fixed.

adrai · 2023-08-07T16:29:24Z

So can we close this issue?

ximex · 2023-08-07T16:32:53Z

For me it is fixed. @esetnik also for you?

esetnik · 2023-08-07T17:06:19Z

I am still experiencing the issue and stuck on the older version until it is resolved. The last version that is able to lint my project without Allocation failed - JavaScript heap out of memory errors is:

[email protected]
[email protected]

omoifodarling · 2023-08-07T18:32:01Z

Yes you may Sent from my iPhone 14 Pro Max 📲 On Aug 7, 2023, at 12:29 PM, Adriano Raiano ***@***.***> wrote: So can we close this issue? — Reply to this email directly, view it on GitHub<#1883 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADZWDNIBU45QD23UHLWERO3XUEJXBANCNFSM6AAAAAAS5J7FBE>. You are receiving this because you commented.Message ID: ***@***.***>

adrai · 2023-08-07T18:34:50Z

@esetnik seems @pedrodurek is still waiting for an example by you?

esetnik · 2023-08-07T18:36:12Z

@ximex can you tell me which versions of @typescript-eslint you are using and provide me with your eslint config? I'd like to try to reproduce it using your configs since they are working for you.

ximex · 2023-08-08T07:45:00Z

it worked with 5.62.0 and also with 6.3.0

the config (@typescript-eslint@^6.3.0) without the huge list of rules:

module.exports = {
	"root": true,
	"env": {
		"browser": true,
		"node": true,
		"commonjs": true,
		"es2023": true,
		"jest/globals": true,
	},
	"parser": "@typescript-eslint/parser",
	"parserOptions": {
		"ecmaVersion": 2023,
		"sourceType": "module",
		"ecmaFeatures": {
			// "impliedStrict": true,
			"jsx": true,
		},
		"project": true,
		"extraFileExtensions": [".json"],
	},
	"settings": {
		"react": {
			"version": "detect",
		},
		// "jest": {
		// 	"version": "29",
		// },
	},
	"plugins": [
		"@typescript-eslint",
		"react",
		"react-hooks",
		"i18next",
		"jest",
		"jest-extended",
	],
	"extends": [
		"eslint:recommended",
		"plugin:node/recommended",
		"plugin:react/jsx-runtime",
	],
	"rules": {
		...
	},
};

esetnik · 2023-08-08T18:19:00Z

@ximex do you have @typescript-eslint/no-misused-promises enabled?

ximex · 2023-08-09T08:37:34Z

yes

stale · 2023-09-17T06:07:05Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

esetnik · 2023-09-18T21:36:02Z

please mark as not stale

bencerf · 2023-12-13T22:33:05Z

"i18next": "^23.4.2",
"react-i18next": "^13.0.3",
with this versions tested it looks like it is fixed.

I confirm what @ximex said, with theses version, i don't have any more JS heap out of memory error !! 👏 🙌
EDIT: after developping more, I got the JS heap out of memory error... 😭

We're just upgrading from v22 to @latest v23 (see below) but TSC just die after making any changes and waiting 15sec...

Here our short listed package.json that failed :

"dependencies": {
  // ...
  "i18next": "^23.7.7",
  "i18next-chained-backend": "^4.6.2",
  "i18next-http-backend": "^2.4.2",
  "i18next-parser": "^8.9.0",
  "i18next-resources-to-backend": "^1.2.0",
  // ...
  "react-i18next": "^13.5.0"
},

Fyi, our devDependencies:

"devDependencies": {
  // ...
  "@typescript-eslint/eslint-plugin": "^5.60.1",
  "@typescript-eslint/parser": "^5.60.1",
  // ...
  "eslint": "^8.43.0",
  "eslint-config-prettier": "^8.8.0",
  "eslint-config-standard": "^17.1.0",
  "eslint-plugin-import": "^2.27.5",
  "eslint-plugin-no-restricted-imports": "^0.0.0",
  "eslint-plugin-playwright": "^0.15.3",
  "eslint-plugin-prettier": "^4.2.1",
  "eslint-plugin-react": "^7.32.2",
  "eslint-plugin-react-hooks": "^4.6.0",
  "eslint-plugin-simple-import-sort": "^10.0.0",
  "eslint-plugin-unused-imports": "^2.0.0"
  // ...
},

I don't really know how I could provide a reproducible example repository for this sort of bug, sorry...

bencerf · 2023-12-14T19:05:49Z

Sorry about my previous comment, we finally managed to fix our Error: Worker terminated due to reaching memory limit: JS heap out of memory by increasing virtual memory (NODE_OPTIONS) of node with 8Gb (as explained here).

Working for us with @latest i18next & react-i18next :

    "dependencies": {
      "i18next": "^23.7.7",
      "i18next-chained-backend": "^4.6.2",
      "i18next-http-backend": "^2.4.2",
      "i18next-parser": "^8.9.0",
      "i18next-resources-to-backend": "^1.2.0",
      // ...
      "react-i18next": "^13.5.0"
    },

Here our script using vite :

  "scripts": {
    "start": "export NODE_OPTIONS=--max-old-space-size=8192 && vite",
  }

adrai added the typescript label Dec 13, 2022

stale bot added stale and removed stale labels Dec 31, 2022

stale bot added the stale label Jan 17, 2023

adrai removed the stale label Jan 17, 2023

adrai assigned pedrodurek Jan 17, 2023

pedrodurek mentioned this issue Feb 13, 2023

Redesign t function types #1911

Merged

7 tasks

This was referenced Feb 28, 2023

TypeScript ESLint crash after 22.4.4 when passing TFunction #1901

Closed

Bug: Eslint hangs and gobbles memory with i18next version 22 and typescript-eslint typescript-eslint/typescript-eslint#6538

Closed

stale bot added the stale label Mar 18, 2023

adrai removed the stale label Mar 18, 2023

stale bot added the stale label Apr 2, 2023

adrai removed the stale label Apr 2, 2023

stale bot added the stale label May 4, 2023

adrai removed the stale label May 4, 2023

stale bot added the stale label Jun 15, 2023

adrai removed the stale label Jun 15, 2023

This was referenced Jun 17, 2023

Add test #1971

Closed

CustomTypeOptions pollute and break all other instances #1976

Closed

esetnik mentioned this issue Jun 21, 2023

[v23.0.1] - Type instantiation is excessively deep and possibly infinite #1972

Closed

esetnik mentioned this issue Jul 12, 2023

Type instantiation is excessively deep and possibly infinite #1921

Closed

stale bot added the stale label Sep 17, 2023

adrai removed the stale label Sep 17, 2023

adrai mentioned this issue Feb 17, 2024

Typescript performance regression #2138

Closed

Run eslint -> JavaScript heap out of memory #1883

Run eslint -> JavaScript heap out of memory #1883

Comments

ximex commented Dec 13, 2022

🐛 Bug Report

To Reproduce

Expected behavior

Your Environment

adrai commented Dec 13, 2022

esetnik commented Dec 14, 2022

jansedlon commented Dec 15, 2022 • edited

esetnik commented Dec 20, 2022 • edited

stale bot commented Dec 31, 2022

esetnik commented Jan 2, 2023

esetnik commented Jan 4, 2023

esetnik commented Jan 4, 2023

stale bot commented Jan 17, 2023

ximex commented Jan 17, 2023 • edited

CreativeTechGuy commented Jan 22, 2023

esetnik commented Feb 17, 2023

stale bot commented Mar 18, 2023

stale bot commented Apr 2, 2023

stale bot commented May 4, 2023

adrai commented Jun 15, 2023

esetnik commented Jun 15, 2023

pedrodurek commented Jun 22, 2023

esetnik commented Jun 22, 2023

adrai commented Jul 26, 2023

esetnik commented Jul 26, 2023

adrai commented Jul 28, 2023

ximex commented Aug 7, 2023

adrai commented Aug 7, 2023

ximex commented Aug 7, 2023

esetnik commented Aug 7, 2023

omoifodarling commented Aug 7, 2023 via email

adrai commented Aug 7, 2023

esetnik commented Aug 7, 2023

ximex commented Aug 8, 2023 • edited

esetnik commented Aug 8, 2023

ximex commented Aug 9, 2023

stale bot commented Sep 17, 2023

esetnik commented Sep 18, 2023

bencerf commented Dec 13, 2023 • edited

bencerf commented Dec 14, 2023 • edited

jansedlon commented Dec 15, 2022 •

edited

esetnik commented Dec 20, 2022 •

edited

ximex commented Jan 17, 2023 •

edited

ximex commented Aug 8, 2023 •

edited

bencerf commented Dec 13, 2023 •

edited

bencerf commented Dec 14, 2023 •

edited