You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Currently, components/MainPanelSchedule.js produces incorrect or suboptimal HTML:
No key is provided for slot entities (i.e. the classes in the weekly visualizer), which is bad for performance. See here for a discussion of keys. It would be ideal to use the courseIds, which serve as references in the store as key.
Fix illegal markup. #40
Fix incorrect rendering abstractions. #41
Plan
In addition to fixing these issues, it is worth considering potential alternative rendering strategies for the schedule, as accurate placement of the slot entities has proven tricky, especially across browsers and screen resolutions.
From @PythonNut on January 12, 2018 6:39
This is a meta issue.
Currently,
components/MainPanelSchedule.js
produces incorrect or suboptimal HTML:No
key
is provided for slot entities (i.e. the classes in the weekly visualizer), which is bad for performance. See here for a discussion of keys. It would be ideal to use thecourseId
s, which serve as references in the store askey
.Fix illegal markup. #40
Fix incorrect rendering abstractions. #41
Plan
In addition to fixing these issues, it is worth considering potential alternative rendering strategies for the schedule, as accurate placement of the slot entities has proven tricky, especially across browsers and screen resolutions.
Copied from original issue: hyperschedule/hyperschedule#38
The text was updated successfully, but these errors were encountered: