Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Cleanup weekly schedule rendering #2

Open
3 tasks
raxod502 opened this issue Jul 3, 2018 · 0 comments
Open
3 tasks

Cleanup weekly schedule rendering #2

raxod502 opened this issue Jul 3, 2018 · 0 comments
Labels
good first issue Good for newcomers react

Comments

@raxod502
Copy link
Contributor

raxod502 commented Jul 3, 2018

From @PythonNut on January 12, 2018 6:39

This is a meta issue.

Currently, components/MainPanelSchedule.js produces incorrect or suboptimal HTML:

  1. No key is provided for slot entities (i.e. the classes in the weekly visualizer), which is bad for performance. See here for a discussion of keys. It would be ideal to use the courseIds, which serve as references in the store as key.

  2. Fix illegal markup. #40

  3. Fix incorrect rendering abstractions. #41

Plan

In addition to fixing these issues, it is worth considering potential alternative rendering strategies for the schedule, as accurate placement of the slot entities has proven tricky, especially across browsers and screen resolutions.

Copied from original issue: hyperschedule/hyperschedule#38

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers react
Projects
None yet
Development

No branches or pull requests

1 participant