Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: Improve decoding of ChainId #4197

Open
Erigara opened this issue Jan 12, 2024 · 2 comments
Open

[refactor]: Improve decoding of ChainId #4197

Erigara opened this issue Jan 12, 2024 · 2 comments
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@Erigara
Copy link
Contributor

Erigara commented Jan 12, 2024

          This could be improved by using constructor `fn new(inner: impl Into<Box<str>>)`.

I will extract it into separate good first issue.

Originally posted by @Erigara in #4185 (comment)

Idea is to remove redundant clone by directly convert from String to Box<str>.

@Erigara Erigara added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Jan 12, 2024
@mversic mversic changed the title [refcator]: Improve decoding of ChainId [refactor]: Improve decoding of ChainId Jan 12, 2024
@mversic
Copy link
Contributor

mversic commented Jan 12, 2024

remove custom Decode implementation for ChainId after this PR is merged

@Erigara
Copy link
Contributor Author

Erigara commented Jan 12, 2024

@mversic oh it will be much better solution

@nxsaken nxsaken added this to Iroha Sep 4, 2024
@nxsaken nxsaken moved this to Backlog in Iroha Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

3 participants