Enforce correct warp config filenames in registry #209
Assignees
Labels
Comments
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 6, 2025
) ### Description <!-- Summary of change. Example: Add sepolia chain --> Fixes #439 and #209 - Change `combine` and `optimize-svg` jobs to only run when commited to `main` - Add script to validate chains and warp routes - Add `step` in `ci.ym`l test job to run these - For chains it will check for missing `deployer` field and if its missing logo file - For warp routes it will check for missing config file and if chain names are ordered correctly - Updated `chain` test to check if `isTestnet` is set properly - Update `warp-routes` test to check for `logoURI` field ### Backward compatibility <!-- Are these changes backward compatible? Note that additions are backwards compatible. Yes/No --> Yes ### Testing Manual
ltyu
pushed a commit
that referenced
this issue
Jan 7, 2025
) ### Description <!-- Summary of change. Example: Add sepolia chain --> Fixes #439 and #209 - Change `combine` and `optimize-svg` jobs to only run when commited to `main` - Add script to validate chains and warp routes - Add `step` in `ci.ym`l test job to run these - For chains it will check for missing `deployer` field and if its missing logo file - For warp routes it will check for missing config file and if chain names are ordered correctly - Updated `chain` test to check if `isTestnet` is set properly - Update `warp-routes` test to check for `logoURI` field ### Backward compatibility <!-- Are these changes backward compatible? Note that additions are backwards compatible. Yes/No --> Yes ### Testing Manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The warp route IDs are
${tokenSymbol}/${alphabeticallyOrderedChainList}but some of the warp config filenames don't correctly order the chain names alphabetically. This will cause confusion.Create a CI that enforces the file names match the IDs
The text was updated successfully, but these errors were encountered: