Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope this one can be mentioned at readme #67

Open
lili21 opened this issue Apr 7, 2017 · 2 comments
Open

Hope this one can be mentioned at readme #67

lili21 opened this issue Apr 7, 2017 · 2 comments

Comments

@lili21
Copy link

lili21 commented Apr 7, 2017

h('div#menu', { style: { 'background-color': '#2f2', 'opacity': 1 } })

This won't work, style property's value must be string.

@senko
Copy link

senko commented Apr 9, 2017

I recently updated from hyperscript 1.4.6 to 2.0.2 and hit this same problem. Looking at the relevant commits, it seems that the change that introduced this was: c1f03e0

It looks to me like this is a bug and not indended behaviour. In that case, @dominictarr would you accept a PR that fixes this? The fix is easy, don't use match if the value is not a string, and would be happy to provide it with accompanying test.

@dominictarr
Copy link
Collaborator

@senko yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants