{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":3967129,"defaultBranch":"master","name":"hydrogen","ownerLogin":"hydrogen-music","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-04-08T21:47:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1278744?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718741041.0","currentOid":""},"activityList":{"items":[{"before":"908b843c68d1222d1042b6fd2c483f2f58e79743","after":"72fddf29a6c9e62b83adb21f93efff25b57a9ba2","ref":"refs/heads/phil-fix-1957-partial-artifacts","pushedAt":"2024-06-19T14:36:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"tests: deactivate UTF-8 drumkit export test\n\nfor all platform it fails at different lines. It is best to deactivate it altogether till proper UTF-8 support is implemented","shortMessageHtmlLink":"tests: deactivate UTF-8 drumkit export test"}},{"before":null,"after":"908b843c68d1222d1042b6fd2c483f2f58e79743","ref":"refs/heads/phil-fix-1957-partial-artifacts","pushedAt":"2024-06-18T20:04:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"tests: fix DrumkitExportTest\n\nsince we do not support UTF8 encoding in drumkit export, we check whether it is _not_ working and add an additional test for a working export of a ASCII encoded drumkit.","shortMessageHtmlLink":"tests: fix DrumkitExportTest"}},{"before":"c8f8ce309bfdbf4d020a56b1651bef7e915a454c","after":"76c8884afe3b546cf79aaf99265351f223874733","ref":"refs/heads/phil-fix-1957-artifacts","pushedAt":"2024-06-18T18:20:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"tests: fix TestHelper\n\nby removing dead code","shortMessageHtmlLink":"tests: fix TestHelper"}},{"before":"543dc48e5121e7e034c8e26a157d89315688b1cb","after":"14ab85a3f310d1d8ff40ddd8a6446d8c69f860df","ref":"refs/heads/pm-fixing-1933-artifacts","pushedAt":"2024-06-17T19:11:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"ChangeLog: add fix","shortMessageHtmlLink":"ChangeLog: add fix"}},{"before":null,"after":"543dc48e5121e7e034c8e26a157d89315688b1cb","ref":"refs/heads/pm-fixing-1933-artifacts","pushedAt":"2024-06-17T19:00:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"gui: set overall minimum height\n\nprevious minimum height was too smaller and some parts of the `InstrumentRack` showing the layer view of the `InstrumentEditor` were chopped off.\n\nFixes #1933 and #1347","shortMessageHtmlLink":"gui: set overall minimum height"}},{"before":"3e5f89e19782de78978b9f8fcfe6df3fbad1c574","after":"c8f8ce309bfdbf4d020a56b1651bef7e915a454c","ref":"refs/heads/phil-fix-1957-artifacts","pushedAt":"2024-06-14T05:37:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"Drumkit: log libarchive version\n\nas this turns out to be quite crucial. The fix I am writting is not working in older versions (3.4.0) and results in a segfault in particular versions - 3.6.2 and 3.7.2. That is not promissing","shortMessageHtmlLink":"Drumkit: log libarchive version"}},{"before":"0909129d35e536e5d05e93b5fca1ceff561aadf7","after":null,"ref":"refs/heads/pm-master-merge-jack-integration-artifacts","pushedAt":"2024-06-13T05:25:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"}},{"before":"49f5ab53b8b139a058bf89fccc3e7782bf0f6284","after":"3d8504eafd22335c3892f8ef314d5eda83cbeaa6","ref":"refs/heads/master","pushedAt":"2024-06-13T05:25:41.000Z","pushType":"pr_merge","commitsCount":114,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"Merge pull request #1979 from hydrogen-music/pm-master-merge-jack-integration-artifacts\n\nMerge jack integration test and timebase fixes","shortMessageHtmlLink":"Merge pull request #1979 from hydrogen-music/pm-master-merge-jack-int…"}},{"before":"0f8689dbb09039fb7b7cf38a44a5edaac8ab0e71","after":"c29121a42757e1f21b934bdf087849f51f3a1b36","ref":"refs/heads/releases/1.2","pushedAt":"2024-06-12T19:11:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"tests: use absolute song paths in Timebase test\n\nmaster is not as forgiving in the argument of `-s`. An absolute path is required","shortMessageHtmlLink":"tests: use absolute song paths in Timebase test"}},{"before":"d0d36caa58d18f71fd878e0ca5d1de73f0458ea1","after":"0909129d35e536e5d05e93b5fca1ceff561aadf7","ref":"refs/heads/pm-master-merge-jack-integration-artifacts","pushedAt":"2024-06-12T19:10:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"tests: use absolute song paths in Timebase test\n\nmaster is not as forgiving in the argument of `-s`. An absolute path is required","shortMessageHtmlLink":"tests: use absolute song paths in Timebase test"}},{"before":null,"after":"d0d36caa58d18f71fd878e0ca5d1de73f0458ea1","ref":"refs/heads/pm-master-merge-jack-integration-artifacts","pushedAt":"2024-06-12T06:27:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"i18n: update translation\n\nafter cherry-picking changes of #1977","shortMessageHtmlLink":"i18n: update translation"}},{"before":null,"after":"4b8865c893349596f26f2d93a3ae69093c0ae2ab","ref":"refs/heads/pm-fixing-1933","pushedAt":"2024-06-12T06:21:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"stub implementing #1933","shortMessageHtmlLink":"stub implementing #1933"}},{"before":"68628e9830cdc43ce7e8e871fae3baabaccebdf4","after":null,"ref":"refs/heads/phil-jack-integration-test-win32-artifacts","pushedAt":"2024-06-11T17:20:18.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"}},{"before":"f5abe094ee39d92c7b2c5fc38a75fc29dea0f8a8","after":null,"ref":"refs/heads/phil-jack-integration-test-integration","pushedAt":"2024-06-11T17:20:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"}},{"before":"e6dcdb30b09d5531323c0008227026d6aff41d4a","after":null,"ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-11T17:19:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"}},{"before":"d1f23c8b3d8758964100c9f871c758256360cdfe","after":"0f8689dbb09039fb7b7cf38a44a5edaac8ab0e71","ref":"refs/heads/releases/1.2","pushedAt":"2024-06-11T17:19:49.000Z","pushType":"pr_merge","commitsCount":112,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"Merge pull request #1977 from hydrogen-music/phil-jack-integration-test-artifacts\n\nFix JACK synchronization (#1953)","shortMessageHtmlLink":"Merge pull request #1977 from hydrogen-music/phil-jack-integration-te…"}},{"before":"49ed0334f1066d7a0a3e10d6ab40912ada59ef00","after":"e6dcdb30b09d5531323c0008227026d6aff41d4a","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-10T18:04:58.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"AudioEngine: support Timebase in Pattern Mode\n\nin the current state of the code there is no reason to not support tempo changes broadcasted by an external Timebase master in Pattern Mode as well","shortMessageHtmlLink":"AudioEngine: support Timebase in Pattern Mode"}},{"before":"653acfe86d84bc3d7f544a45ee9207e4e9316aa3","after":"49ed0334f1066d7a0a3e10d6ab40912ada59ef00","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-09T17:49:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"AudioEngine: fix ifdefs","shortMessageHtmlLink":"AudioEngine: fix ifdefs"}},{"before":"767ad9ee7dca52fc2dd2c631f4a46e63344e4cc7","after":"653acfe86d84bc3d7f544a45ee9207e4e9316aa3","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-09T17:02:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"test: missing ifdefs again","shortMessageHtmlLink":"test: missing ifdefs again"}},{"before":"f7c754fb100e78252236da26eb84bb21612ccfc2","after":"767ad9ee7dca52fc2dd2c631f4a46e63344e4cc7","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-08T19:41:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"test: missing ifdefs again","shortMessageHtmlLink":"test: missing ifdefs again"}},{"before":"5cb10ca9a443b4e8f10462ab2c8f98417658c7c1","after":"f7c754fb100e78252236da26eb84bb21612ccfc2","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-08T18:49:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"test: missing ifdefs again","shortMessageHtmlLink":"test: missing ifdefs again"}},{"before":"7e2dde8d9770e36593e1043c32476d853f63ebbf","after":"5cb10ca9a443b4e8f10462ab2c8f98417658c7c1","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-08T18:36:02.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"jack: rework BBT relocation\n\nThe first time we get a valid BBT information, we consider this a relocation and calculate the new position based on BBT.\n\nI have to admit I had this already on my todo list once or twice but abstained from it since it has a really bad UX consequence for Hydrogen: clicking on a position on the ruler is not guaranteed anymore to make Hydrogen relocate to this position.\n\nThe reason is as follows: Hydrogen calculates the frame for the desired position based on the current tempo and measure information provided by the JACK Timebase master - which will lead to wrong results in case of tempo and measure changes. But that is all we can base or work on. The Hydrogen sends this frame to the JACK server, which will broadcast it without any BBT info. We relocate to the desired location. But in the next processing cycle the Timebase master fills the BBT information corresponding to the frame and broadcasts it.\n\nIf we a) consider this a relocation and calculate the new position based on BBT we loose the ability to relocate transport from within Hydrogen. If we b), just use the tempo information and remain at the same location (as done previously) we only use part of the BBT information and are in a wrong and inconsistent transport state. To c) do not act on the BBT info at all, we already support by disabling BBT support within the Preferences.\n\nAs far as I see it we can only go with a). But it is ugly and I am a little bit annoyed of the bad design of the JACK server and how much work it forces me to do when still the results do behave soo badly. But apart from a disclaimer in the manual there is not much we can do here. (If there would be a way to request frame information for a particular BBT point, everything would be fine.)","shortMessageHtmlLink":"jack: rework BBT relocation"}},{"before":"203e414a9c1286355e44028d589a4143618daef9","after":"49f5ab53b8b139a058bf89fccc3e7782bf0f6284","ref":"refs/heads/master","pushedAt":"2024-06-07T19:12:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"Use CXXFLAGS over CMAKE_CXX_FLAGS\n\nas a follow-up to 9e0ab60e334da32eb1712986ea01b1879c2405d1 we now use the proper environmental variable to pass CXX compiler flags to `cmake`","shortMessageHtmlLink":"Use CXXFLAGS over CMAKE_CXX_FLAGS"}},{"before":"6a759376185b27f35a34617cd957d6209bde58b4","after":"203e414a9c1286355e44028d589a4143618daef9","ref":"refs/heads/master","pushedAt":"2024-06-07T19:07:52.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"Merge pull request #1978 from tartina/env\n\ncmake: Do not mask CXXFLAGS environment variable","shortMessageHtmlLink":"Merge pull request #1978 from tartina/env"}},{"before":"a3bacbfad27c36baea6e3b0ea258477a980372aa","after":"7e2dde8d9770e36593e1043c32476d853f63ebbf","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-06T20:01:04.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"jack: handle frame glitches in JackTimebaseCallback\n\n\t// In the face of heavy load - can be triggered by enabling JackAudioDriver,\n\t// TransportPosition, and AudioEngine debug logs - XRuns occur and the frame\n\t// information provided by the JACK server glitches(!!!!). So, it just\n\t// changes under the hood in the pointer passed to this callback. The very\n\t// quantity we should calculate BBT information based on. Well we try a\n\t// second time in order to avoid glitches.\n\nWhile this is definitely a JACK bug, we still need to cope for it","shortMessageHtmlLink":"jack: handle frame glitches in JackTimebaseCallback"}},{"before":"7b24ff28d1905dc59fbe2da02e8124d62db9da5a","after":"a3bacbfad27c36baea6e3b0ea258477a980372aa","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-05T20:28:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"tests: rework BBT relocation testing\n\nPreviously we kept track of the number of relocation attempts in order to check whether are relocation loops - Hydrogen regards the same position a relocation over and over again. But this did not work.\n\nFor one when triggering relocation in the listener, no valid BBT position will be provided and relocation will work using the classic frame approach. It can only be tested in the additional BBT relocation test where it is now done explicitly","shortMessageHtmlLink":"tests: rework BBT relocation testing"}},{"before":"715299386821ec799664a3850971c2d10e0b2495","after":"7b24ff28d1905dc59fbe2da02e8124d62db9da5a","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-05T17:31:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"AudioEngineTests: fix header","shortMessageHtmlLink":"AudioEngineTests: fix header"}},{"before":"0c075bc523540a1ba28615f67a740135b8079a24","after":"715299386821ec799664a3850971c2d10e0b2495","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-06-04T19:59:59.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"test: consistency of updateTransportPosition","shortMessageHtmlLink":"test: consistency of updateTransportPosition"}},{"before":"73bd6f642ec6926ab8f160065b0222da85bd8e3f","after":"0c075bc523540a1ba28615f67a740135b8079a24","ref":"refs/heads/phil-jack-integration-test-artifacts","pushedAt":"2024-05-26T19:21:26.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"jack: use provided frame in TimebaseCallback\n\nthere had been a design flaw in `JackAudioDriver::JackTimebaseCallback`. Instead of just using the BBT information of the current transport position in the AudioEngine, the BBT information has to be provided for frame the JACK server supplied to the callback.\n\nIt works a bit but not flawlessly yet. Whenever a XRun occurs, the frame information provided as function input IS CHANGED BY THE JACK SERVER. So, while calculating the BBT information for a frame the JACK server just replaces that very frame. WTF? We have to take this into account because it is bad and it makes our integration test fails as soon as we activate a bunch of log messages","shortMessageHtmlLink":"jack: use provided frame in TimebaseCallback"}},{"before":"484cec59d298327ad55ab3fcdc6fa96d30c381ee","after":"6a759376185b27f35a34617cd957d6209bde58b4","ref":"refs/heads/master","pushedAt":"2024-05-23T17:16:40.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"theGreatWhiteShark","name":null,"path":"/theGreatWhiteShark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14164547?s=80&v=4"},"commit":{"message":"add INSTRUMENT_PITCH endpoint\n\nto both OSC and MIDI api","shortMessageHtmlLink":"add INSTRUMENT_PITCH endpoint"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEaaeyWwA","startCursor":null,"endCursor":null}},"title":"Activity · hydrogen-music/hydrogen"}