Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + Shift + ] Shortcut not working on Windows 10 #123

Open
ghost opened this issue Jan 7, 2020 · 9 comments
Open

Ctrl + Shift + ] Shortcut not working on Windows 10 #123

ghost opened this issue Jan 7, 2020 · 9 comments

Comments

@ghost
Copy link

ghost commented Jan 7, 2020

Hey guys, loving the style of this application.
I seem to have found an issue on the two windows 10 machines I'm using where the Ctrl + Shift + ] shortcut doesn't work like it should, though this wasn't present on a mac I borrowed to test.

I can still use Ctrl + Shift + [ to move back a file, and both functions work from the 'navigation' tab in the toolbar, but the next file shortcut isn't working.

@neauoire
Copy link
Member

neauoire commented Jan 9, 2020

We'll have a look :) Stay tuned

@idimitrijevic
Copy link

I'm also facing issues with quick inserts shortcuts - none of them work :/
Really love the app

@neauoire
Copy link
Member

neauoire commented Jan 9, 2020

Inserts don't work on Windows?
When you press ctrl+i & ctrl+d nothing happens?
Can you open an issue for the specific problem?

@idimitrijevic
Copy link

Yes, sorry :/
I will open an issue
Thanks for the quick response!

@elliottcandrew
Copy link

any news on this?

ctrl + shift + ] is also not working for me on win10

@slpysiren
Copy link

Also having this issue on Linux

@Lucaffo
Copy link

Lucaffo commented Jun 26, 2021

Also having this issue on Windows Today.
It would be an awesome feature, still not find how and why it's not working.

I see the code for 10 minutes and find that:

image

Next_page (The function that need to be called), it's binded in Events.js only when a file is dropped in.

There is no binding in the file for ctrl+shift+] / [

image

@Lucaffo
Copy link

Lucaffo commented Jun 28, 2021

Ok i've realized now a fact.

Which keyboard layout did you use? Because most non American Layout have '[' that can be used only if you press ctrl+alt.

if the shortcut require a ctrl+maiusc(Aka shift)+] it should be ctrl+alt+maiusc+] this is equals to curve brakets { } in most non america keyboards lol.

This means that only US layout can make these shortcuts 😢

My italian layout keyboard:
image

Any US layout keyboard:
image

@sdrwtf
Copy link

sdrwtf commented Jul 13, 2021

@Lucaffo you're right, this behavior is depending on the not US keyboard layout, same problem here with a German layout. This also affects the Toggle Navigation shortcut which is Ctrl + \ by default, but there is an easy fix (or at least workaround).

You can edit the keyboard shortcuts within the desktop/sources/index.html file, I've made the following changes and it works fine on Linux:

/* Navigation with Page-Up and Page-Down keys, ~ line 71 */
left.controller.add('default', 'Navigation', 'Next File', () => { left.navi.next_page() }, 'CmdOrCtrl+Shift+PageDown')
left.controller.add('default', 'Navigation', 'Prev File', () => { left.navi.prev_page() }, 'CmdOrCtrl+Shift+PageUp')
left.controller.add('default', 'Navigation', 'Next Marker', () => { left.navi.next_marker() }, 'CmdOrCtrl+PageDown')
left.controller.add('default', 'Navigation', 'Prev Marker', () => { left.navi.prev_marker() }, 'CmdOrCtrl+PageUp')
/* Navigation Toggle with Super (windows) key, ~ line 76 */
left.controller.add('default', 'View', 'Toggle Navigation', () => { left.navi.toggle() }, 'CmdOrCtrl+Super+S')

After editing the index.html I've rebuild Left with npm rebuild, actually I'm not sure if this is necessary but it worked for me.

There is just one small quirk: in the menu the super key is not displayed in the shortcut info, but that's only cosmetic (and maybe only missing in the German translation file):

image

@neauoire maybe this should be included in the readme? Could save a few recurring questions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants