Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media files are not included when searching for a link or button URL #145

Open
johnbillion opened this issue May 4, 2021 · 1 comment
Open

Comments

@johnbillion
Copy link
Member

Steps to reproduce:

  • Insert some text into a post
  • Highlight some text
  • Click the "Link" button in the block toolbar
  • Search for a phrase that matches an attachment
  • Observe that no matching attachments are found

This is the default behaviour of the link inserter in WordPress, but given the additional smart features of media in Smart Media it would be great if attachments were searched here.

One complication is that the desired link in this case is probably not the attachment permalink but instead is the source URL of the uploaded file.

AC based on a bug report from a client:

As an editor on a site
When I upload a PDF file to the media library
Then I expect to be able to find that file when adding a link to a button on a page
And the link that's used points to the original PDF file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant