Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom crops per insert. #10

Open
peterwilsoncc opened this issue Apr 29, 2019 · 1 comment
Open

Allow custom crops per insert. #10

peterwilsoncc opened this issue Apr 29, 2019 · 1 comment

Comments

@peterwilsoncc
Copy link
Contributor

It would be helpful to allow two modes of custom cropping:

  • Global crops (as is currently the case, stored in the attachment's post meta)
  • Local crops affecting only the current insert in to the post.

Using this image as an example:

Image from the hit musical Dear Evan Hansen

For a story about the Tony Award® winning Ben Platt, I may wish to use this crop:

Image of Tony Award® winner Ben Platt from the hit musical Dear Evan Hansen

Whereas for a story about the Tony Award® winning Rachel Bay Jones, I may wish to use this crop:

Image of Tony Award® winner Rachel Bay Jones from the hit musical Dear Evan Hansen

@roborourke
Copy link
Contributor

Agreed. Right now it's a really tricky as we're not storing the tachyon image URL in the content as of the latest tachyon plugin version. I'll need to double check that the "allow in admin" override doesn't circumvent it but pretty sure that's now the case.

We'd need to support the addition of query parameters to individual image URLs inline and also make sure they're supported and merged properly either in this or the tachyon plugin.

I think we'd need to filter the image components of Gutenberg to support this.

This is partly related to #8 as well - there's a built in Gutenberg component we could use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants