Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option for gap detector to create event on every run when gap is detected #2813

Open
degan6 opened this issue Jun 14, 2020 · 1 comment · May be fixed by #2988
Open

Create option for gap detector to create event on every run when gap is detected #2813

degan6 opened this issue Jun 14, 2020 · 1 comment · May be fixed by #2988

Comments

@degan6
Copy link
Contributor

degan6 commented Jun 14, 2020

Would be nice to have a feature where the gap detector agent creates an event every time its run when a gap is detected instead of just once.

Simple example of use case, if I have a backup job that pings a webhook agent -> gap detector agent and that backup hasn't run in two days. I'd like a constant reminder that the backup is still not running.

Seems simple enough to do:

  • Add a default boolean option to the default on line 32.
  • Add validation check
  • update the check function to look for that option or default to current behavior if its missing.
  • Update the description

Looks like the line that is preventing it from happening now is:
https://github.com/huginn/huginn/blob/master/app/models/agents/gap_detector_agent.rb#L59

I will give this a try, though I've never written ruby.

@degan6 degan6 changed the title Create option for gap detected to create event on every run when gap is detected Create option for gap detector to create event on every run when gap is detected Jun 14, 2020
@dsander
Copy link
Collaborator

dsander commented Jun 14, 2020

Sounds like a neat addition to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants