Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last few lines of the display cutting off #347

Open
offensivelearning opened this issue May 10, 2023 · 2 comments
Open

Last few lines of the display cutting off #347

offensivelearning opened this issue May 10, 2023 · 2 comments

Comments

@offensivelearning
Copy link

offensivelearning commented May 10, 2023

The display gets cut off towards the end as seen in the image. Happens on both Firefox and Chrome on Windows 11. Using WebSSH v 1.6.2.

webssh_display

@kazqvaizer
Copy link

Hey! I found an easy workaround, just decrement one row right here https://github.com/huashengdun/webssh/blob/master/webssh/static/js/main.js#L182

The line must look like this

var rows = parseInt(window.innerHeight / style.height, 10) - 1;

@oneofthemany
Copy link

oneofthemany commented Jan 30, 2024

I think the issue only exists in chrome when in fullscreen

I have amend that line in the following file in my container:

/usr/local/lib/python3.8/site-packages/webssh/static/js/main.js

but it does nothing when in full screen

I have even tried decrementing more than 1 line and I still get the same issue in chrome - Firefox never had the issue

i think the section that needs to be amended is as follows:

  function toggle_fullscreen(term) {
    $('#terminal .terminal').toggleClass('fullscreen');
    term.fitAddon.fit();
  }

as I dont see the issue when I am not in full screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants