-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uri.setQueryParams() doesn't seem to overwrite existing params #7106
Comments
Thanks! I guess the bug is here?
|
My humble opinion is that we better need to fix the scaladoc and add a new method rather than change the behaviour of that function. |
Yeah, I wouldn't disagree. It looks like it's been working this way since v0.20.0. dd7e192 |
Just fyi: there's another method that modifies query parameters in
So neither of those two methods does replace query parameters completely. Now compare to a
So in my opinion, current naming conventions in the library are quite confusing and inconsistent.
Moreover, although the Perhaps, it would be nice if the naming consistency could be addressed in 1.x version at least, wdyt? |
Hi, I was attempting to use Uri.setQueryParams() and noticed it doesn't behave according to the comments:
This munit test passes on 0.23.19-RC3 and 0.23.4 (in a test project that imports http4s), and I would expect it to fail:
The text was updated successfully, but these errors were encountered: