Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sixels on Windows when available #215

Open
johnd0e opened this issue Aug 30, 2024 · 5 comments
Open

Use sixels on Windows when available #215

johnd0e opened this issue Aug 30, 2024 · 5 comments
Labels
compatibility Compatibility (e.g. terminal quirks) feature New feature or request
Milestone

Comments

@johnd0e
Copy link

johnd0e commented Aug 30, 2024

Latest Windows Terminal supports sixels output, and it works when I specify -f sixels option explicitly

Perhaps it would be better to use it by default.

@hpjansson
Copy link
Owner

Yes - at least long term, that's how I'd like it. But we can't distinguish between older Windows Terminal and the newer versions with sixel support, so we should probably wait until more users have upgraded.

Do people generally keep Windows Terminal up to date?

@ykhan21
Copy link

ykhan21 commented Sep 5, 2024

@hpjansson, the yazi developer seems to query the terminal for sixels support like so: (microsoft/terminal#17809 (comment)). I don't know if this is feasible for chafa though.
Also, the current stable release doesn't support sixels, however the current preview release does.
https://github.com/microsoft/terminal/releases

@hpjansson
Copy link
Owner

@hpjansson, the yazi developer seems to query the terminal for sixels support like so: (microsoft/terminal#17809 (comment)). I don't know if this is feasible for chafa though.

It is, I just have to get over my API anxiety and implement an async terminal handler.

@hpjansson hpjansson added this to the 1.16 milestone Oct 11, 2024
@hpjansson hpjansson added feature New feature or request compatibility Compatibility (e.g. terminal quirks) labels Oct 11, 2024
@a-usr
Copy link

a-usr commented Nov 27, 2024

You could use the "Send Device Attributes" escape sequence to detect sixel support.
For Reference see this document
Edit: I just noticed this was basically already proposed, but you can still use the link I provided as a reference, since its the exact same thing

@hpjansson
Copy link
Owner

hpjansson commented Nov 27, 2024

Yep. Similar discussion in #191. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility (e.g. terminal quirks) feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants