Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller.studio.runTrigger should resolve promise regardless of whether a trigger was matched #13

Open
jaipandya opened this issue Feb 11, 2019 · 1 comment
Assignees

Comments

@jaipandya
Copy link

While working with the cms locally, using useLocalStudio = true, evaluateTrigger doesn't exactly behave the way it should. In the case where no trigger was matched, the promise is rejected (which it should resolve to mimic the functionality of CMS run as remote API service)

reject();

When run as an API service, evaluateTrigger always resolves, even when there was no match. This in turn affects the Promise object returned by runTrigger

Also have a look at howdyai/botkit@ef69730

@benbrown
Copy link
Contributor

Interesting point! I'll take a look.

@benbrown benbrown self-assigned this Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants