From f6bc4538e857a1da522ff6cf85840ce4c3ba1be0 Mon Sep 17 00:00:00 2001 From: spwoodcock Date: Wed, 13 Nov 2024 10:31:55 +0000 Subject: [PATCH] fix: hardcode VITE_SYNC_URL param until all env var loading works --- .github/workflows/image_build.yml | 3 ++- .github/workflows/image_build_multi.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/image_build.yml b/.github/workflows/image_build.yml index c74d42f..6f4c600 100644 --- a/.github/workflows/image_build.yml +++ b/.github/workflows/image_build.yml @@ -165,11 +165,12 @@ jobs: tags: ${{ inputs.image_tags || steps.meta.outputs.tags }} # TODO fix to allow passing all env vars and secrets (currently hardcoded) # vars_and_secrets correctly loads to `env.` context, but - # passing into build-args doesn't work + # passing into extra_build_args as build-args doesn't work build-args: | APP_VERSION=${{ github.ref_name }} COMMIT_REF=${{ github.sha }} VITE_API_URL=${{ vars.VITE_API_URL }} + VITE_SYNC_URL=${{ vars.VITE_SYNC_URL }} NODE_ENV=${{ vars.NODE_ENV || 'production' }} MONITORING=${{ vars.MONITORING }} ${{ inputs.extra_build_args }} diff --git a/.github/workflows/image_build_multi.yml b/.github/workflows/image_build_multi.yml index 82502b7..6b57b11 100644 --- a/.github/workflows/image_build_multi.yml +++ b/.github/workflows/image_build_multi.yml @@ -171,11 +171,12 @@ jobs: tags: ${{ inputs.image_tags || steps.meta.outputs.tags }} # TODO fix to allow passing all env vars and secrets (currently hardcoded) # vars_and_secrets correctly loads to `env.` context, but - # passing into build-args doesn't work + # passing into extra_build_args as build-args doesn't work build-args: | APP_VERSION=${{ github.ref_name }} COMMIT_REF=${{ github.sha }} VITE_API_URL=${{ vars.VITE_API_URL }} + VITE_SYNC_URL=${{ vars.VITE_SYNC_URL }} NODE_ENV=${{ vars.NODE_ENV || 'production' }} MONITORING=${{ vars.MONITORING }} ${{ inputs.extra_build_args }}