Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Websocket support on the extension #303

Open
1 task done
LuisMayo opened this issue May 16, 2023 · 2 comments
Open
1 task done

[feature]: Websocket support on the extension #303

LuisMayo opened this issue May 16, 2023 · 2 comments
Labels
CodeDay Issues and PRs associated with the CodeDay Labs partnership good first issue Good for newcomers

Comments

@LuisMayo
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Summary

If available, websocket connections should be redirected through the browser extension, just like HTTP ones.

This has been already suggested in hoppscotch/hoppscotch#2194 but the issue was closed by the author as completed, even though it's not completed.

Why should this be worked on?

Because developing websockets is almost impossible else, since HTTPS pages can only connect to wss sockets, and in development TLS is usually skipped

@amk-dev amk-dev transferred this issue from hoppscotch/hoppscotch Jul 4, 2024
@amk-dev amk-dev added the fosshack Reserved for FOSS Hack Partner Projects Programme label Jul 4, 2024
@HelixY2J
Copy link

This is interesting, initial idea I have is to use an Nginx server to handle wss:// connection from client and proxy them to ws:// connections on the websocket server.This should ensure secure websocket communication over HTTPS. Can this issue be assigned to me under FOSS Hack and I can start working on it

@amk-dev
Copy link
Collaborator

amk-dev commented Jul 22, 2024

Hey @HelixY2J

sorry for the late reply.

this is an issue that needs to be solved on the extension level. right now, you'll hit the websocket endpoint directly from the browser, we need to route this through the extension, so restrictions on normal webpages won'
t cause issues with the connection.

here we're not looking to solve this using nginx or by asking the user to make changes to their setup.

can you think from this perspective and give an updated approch ?

@SanskritiHarmukh SanskritiHarmukh added testmu and removed fosshack Reserved for FOSS Hack Partner Projects Programme labels Aug 16, 2024
@SanskritiHarmukh SanskritiHarmukh added good first issue Good for newcomers and removed testmu labels Oct 7, 2024
@SanskritiHarmukh SanskritiHarmukh added the CodeDay Issues and PRs associated with the CodeDay Labs partnership label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CodeDay Issues and PRs associated with the CodeDay Labs partnership good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants