Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In dark mode, make scroll bar dark as well #227

Open
berkaycimsir opened this issue Sep 14, 2022 · 2 comments
Open

In dark mode, make scroll bar dark as well #227

berkaycimsir opened this issue Sep 14, 2022 · 2 comments
Labels
v1.0 The issue will be addressed in Hope UI 1.0

Comments

@berkaycimsir
Copy link

Is your feature request related to a problem? Please describe.
It would be nice if the colors of the scroll bar also change in dark mode. Currently, it feels weird to have white scroll bar in dark mode.

Describe the solution you'd like
I am new to solid and hopeui so i didn't take a look to the source code yet. But seems like this library built with Stitches.
So, i think there should be a base styles for light and dark mode.

For dark mode we can set colors of the scroll bar as dark colors by using css scroll-bar properties (https://www.w3schools.com/howto/howto_css_custom_scrollbar.asp)

Additional context
Currently, it looks like this:

In light mode In dark mode
Screen Shot 2022-09-15 at 00 59 14 Screen Shot 2022-09-15 at 00 59 28
@luckynumberke7in
Copy link

luckynumberke7in commented Sep 29, 2022

It switches properly for light and dark modes for the website I'm building with hope-ui.

It also switches properly on the hope-ui website for me.

I'm using Firefox 105.0.1 on windows 10.

@fabien-ml
Copy link
Collaborator

fabien-ml commented Sep 29, 2022

Hi, the bug is fixed in hope-ui 1.0, like i said in the README v0.x will stay as is to focus on releasing 1.0.

v1.0 also has new features related to color mode like:

  • support for light, dark or system mode
  • automatic color mode switch when the OS mode changes (in system mode)
  • ability to disable animation when changing color mode, so it's "instant"

@fabien-ml fabien-ml added the v1.0 The issue will be addressed in Hope UI 1.0 label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.0 The issue will be addressed in Hope UI 1.0
Projects
None yet
Development

No branches or pull requests

3 participants