-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Python 3.8 #145
Conversation
Thanks for creating the docker images. Could you please add some hints about what port mappings and directory mapping somebody should do to run the docker images. I mean usually I do it like docker run p:80:80 -v /mydir:/dockerdir derneuere/ownphotos .....something like that. |
I didn't change any features regarding port mappings and directory mapping. The old docker-compose.yml.template should work. It does on my system. I found a couple of issues and updated the image :) |
I know PR is not an issue thread, but I tried to run your docker but i'm stuck on login page. I'm using the old docker-compose template with backend host set to domain. I also tried ip:port, domain:port, domain, "domain" but nothing works :/ |
Ever tried reinstalling it? |
@MrColumbo Thanks for testing! 👍 I found the issue in the frontend. You don't need BACKEND_HOST anymore, linking is now done via ownphotos-proxy. Please download the latest docker image for the frontend. |
@zainlol it was actually sysoppl who reported the issue with the broken backend connection. But i got the same issue and just pulled the latest frontend. I do not get that backend connection error anymore but just a blank white page. In the log directory I noticed that the most recent log is the command_build_similarity_index.log and there I found something interesting: Traceback (most recent call last): The above exception was the direct cause of the following exception: Traceback (most recent call last): ..... not sure if that is related or helpfull at all ;) thanks for your quick support |
P.S.: The blank page actually is not that blank if I look at the source ....it contains thing like that 404 The requested path could not be found |
@MrColumbo I noticed, that if I called something like "localhost:3000/login" as the URL in a new tab, that I would always get a 404 error / a blank page. Could you maybe try to just call the your ownphotos url without pathing? The error in command_build_similarity_index.log seems like a new error. Could you check if the docker container ownphotos still runs after the error and send the other logs like ownphotos.log? |
I get forwarded to /login automatically when I go to / ownphotos.log is zero bytes so far ;) rqworker.log |
P.S.: the error does not stop any container ...they have been and are still all running |
@MrColumbo I can't seem to reproduce the error. Could you run docker-compose up without the -d? It should print all the logs of all the containers. Could you paste the whole console content after you hit the error? |
I have to confess that I tried to login twice since I noticed a lot of action on the output window and wanted to check if the page is still white but did not found the tab ;) |
@MrColumbo Did you already ran ownphotos with an old version or are you trying to set it up for the first time? |
i started setting it up today .....never used it before ... |
@MrColumbo @sysoppl The original dev never pushed some files needed for initialization. Took me some time to figure that one out. I took them from an old docker build. Now it works. |
looks much better now 👍 |
@MrColumbo Yep, the current flow is a bit janky. If something doesn't update, it is probably because you have no authorisation. Open the webconsole and look for a 401 (Unauthorized) Error. Just logout and login again and the things should the show current progress. I will investigate that issue, because it wasn't there a couple of commits ago. Go to the admin area and click on the red icon: Choose the folder listed below and click on update: Go then to the settings page and click on "Start Scanning": In the admin area should be a process. After a while you will see how many pictures it is trying to scan: |
thanks - logging off and logging back in did it |
How long should it take before i see a percentage on the job in the admin area? So far I just see the spinning sign on the left but the progress bar is zero. The last few lines in the ownphotos.log are those 2020-11-16 07:53:40,819 : directory_watcher.py : handle_new_image : 93 : INFO : adding to AlbumDate took 0.02 the rworker.log looks like that 21:48:22 Worker rq:worker:9758af7c63ec472cb9a77aa6dd4065df: started, version 1.6.1 the image similar log looks like that 2020-11-15 15:18:44,144 : main.py : : 50 : INFO : starting server and that is the gunicorn similarity log 127.0.0.1 - - [2020-11-15 21:48:06] "POST /build/ HTTP/1.1" 200 139 0.017821 the other log files have not been updated In the photo section i see blank thumbnails when i go for photos with timestamps (there are 39 photos) |
You have to click the reload button to get the current status. The log says that your scan is done. The blank thumbnails seem like an authorization problem. I created a new image yesterday to improve this behavior. Maybe try logoff and login again 👍 |
logoff and back login again did it again. Next time I will try that before asking ;) |
@MrColumbo I found the error. I have no idea if it ever worked, but it works now :D It should now read the coordinates on new pictures if you have a valid maxbox key. There is also a geocoder based on openstreet maps, where you don't need an api key, but the json response is different. But that could be a nice feature for the future :) There is currently no way to start geocoding for pictures already scanned. |
Fixes #112 and makes building a docker image easier.
Some Jobs are no longer used, because they don't function together with places365.py and face_classify.py. I could not find a reason why. I had to refactor some calls so that it feels the same as before.
You can find up to date docker images under https://hub.docker.com/u/derneuere to confirm that it still works for you.