Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar for Mercedes Me Plugin #1

Open
askovi opened this issue Mar 19, 2021 · 2 comments
Open

Sidecar for Mercedes Me Plugin #1

askovi opened this issue Mar 19, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@askovi
Copy link
Member

askovi commented Mar 19, 2021

https://plugins.hoobs.org/plugin/homebridge-mercedesme

This plugin needs custom UI implementation for getting the token from the mercedes api.

@mkellsy mkellsy changed the title Implement custom config for mercedesme Implement Custom Config for Mercedes Me Plugin Mar 20, 2021
@mkellsy
Copy link
Contributor

mkellsy commented Mar 27, 2021

I reworked the UI plugin system. We now can load UI plugins from the hoobs folder in the plugin. I also added what I am calling a sidecar. A sidecar is a module that is released to NPM. Then on our plugins server we can set that module in the sidecar field. Then the sidecar is installed, upgraded and removed along with the plugin.

yarn add plugin sidecar

This allows us to make config plugins for plugins that don't have one. It also allows plugin devs to do the same thing. This is great because devs can keep their code clean (hopefully HB follows on this).

Next Steps
Make a sidecar for the mercedes and nest plugins.

@mkellsy mkellsy changed the title Implement Custom Config for Mercedes Me Plugin Sidecars for Mercedes Me, Nest, and Nest Cam Plugins Mar 27, 2021
@mkellsy mkellsy transferred this issue from hoobs-org/gui Apr 6, 2021
@mkellsy mkellsy added the enhancement New feature or request label Apr 6, 2021
@mkellsy
Copy link
Contributor

mkellsy commented Jul 30, 2021

Nest is done

@mkellsy mkellsy changed the title Sidecars for Mercedes Me, Nest, and Nest Cam Plugins Sidecar for Mercedes Me Plugin Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants