Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out better interface #56

Open
honzajavorek opened this issue Jan 6, 2025 · 0 comments
Open

Figure out better interface #56

honzajavorek opened this issue Jan 6, 2025 · 0 comments

Comments

@honzajavorek
Copy link
Owner

I don't like how the library currently works. It should transparently construct requests to the Fio API and return responses as nice PyDantic objects/dicts. I don't think it should do much more (retries, type conversions, etc. are fine). I don't like how it tries to separate info and transactions into separate methods, although the original API has no such thing, and I think such stuff should be deprecated. Maybe there could be minimal caching involved to provide info if called right after transactions, etc., but I'm afraid this only adds complexity for no added benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant