Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on serve-static properly #81

Open
renhiyama opened this issue Sep 13, 2023 · 3 comments
Open

Work on serve-static properly #81

renhiyama opened this issue Sep 13, 2023 · 3 comments

Comments

@renhiyama
Copy link
Contributor

just keep it normal, like dont serve index.html unless explicitly set to...

app.use('/__reejs/**', serveStatic({ root: './.reejs/', rewriteRequestPath:(p)=>p.replace('__reejs','') }));
app.use('/', serveStatic({ file: "./.reejs/serve/index.html" }));
app.use('/**', serveStatic({ root: './public/' }));

as of @hono/[email protected], this code still doesnt work properly ...

This above code doesnt seve files inside .reejs folder properly, serves index.html when didnt ask to, and neither file option seems to work for me.

While it sounds reasonable to have served index.html automatically, I would suggest making that opt-in.
Like:

app.use('/', serveStatic({ staticWebsite: true });

would just do the job.

@renhiyama
Copy link
Contributor Author

On top of that, it would be cool if I could intercept and modify file contents, which will only serve the modified file, and not apply changes to the real file. Something like modifyFileContent would sound cool!

@ryands17
Copy link

ryands17 commented Nov 7, 2023

@renhiyama I'm facing the same issue. Is there any workaround? I tried serving static files from the public folder but that didn't work:

app.use('/static/**', serveStatic({ root: './public/' }));

@renhiyama
Copy link
Contributor Author

@ryands17 I use hono w/ reejs + packit. Since packit is a code generator, I have configured it to read dir, get appropriate content type header and save the data as a json array to the final code. Then packit is configured to write a for loop on that array which registers route per file separately.
This is just a small & easy workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants