-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspect_app() is not the only possible source of a bundle identifier #40
Comments
So let me get this straight- I hear you about I think it's very safe to assume that an app, if downloaded, will have a bundle ID, so yes, you can build a package recipe, knowing that it's going to need something to get the bundle ID (and version). What that something is, is tricky. I think AppDmgVersioner right before PkgCreator is a good candidate, as it should be able to handle ANYTHING that is going to be immediately preceding PkgCreator. Right? |
Yes, if we've run If we haven't successfully inspected an app at some point along the line, it's likely that RR isn't going to be able to produce a full recipe set without manual intervention. But "likely" ≠ "guaranteed." I'll try to find some edge case examples. |
At the moment, Recipe Robot doesn't build a pkg recipe if there's no bundle_id in facts. However, I don't think we've considered that there are other possible ways to determine the bundle identifier even if we weren't able to collect it during
inspect_app()
.SparkleUpdateInfoProvider
grabs.AppDmgVersioner
can be used to determine a bundle identifier. As long as we include that before thePkgCreator
processor, we should be good to go.The text was updated successfully, but these errors were encountered: