-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new SourceForgeBestReleaseURLProvider processor #114
Comments
That's great, @n8felton! Are there still any situations in which @jessepeterson's SourceForgeURLProvider would still be better and/or the preferred processor? Does this new processor cover all the existing use cases of SourceForgeURLProvider, and then some? |
There is one pitfall to this processor; reliance on the SourceForge project team to update their "best release." A good example of this is https://sourceforge.net/projects/filezilla/. https://sourceforge.net/projects/filezilla/best_release.json has |
I've created a new SourceForgeBestReleaseURLProvider shared processor at https://github.com/autopkg/n8felton-recipes/blob/master/SharedProcessors/SourceForgeBestReleaseURLProvider.py that gives us another option for downloading files from SourceForge. This SourceForgeBestReleaseURLProvider shared processor could be used as either the primary processor or as a fallback processor for SourceForge projects.
As an example:
This currently fails, but could instead use my shared processor (or the code from my shared processor) as a fallback (or primary, and use the current processor as the fallback) to locate the download instead.
Optionally, I have also created a new MD5Checksum shared processor that complements the SourceForgeBestReleaseURLProvider shared processor as the SourceForge Release API provides the MD5 checksum of the available project downloads. https://github.com/autopkg/n8felton-recipes/blob/master/SharedProcessors/MD5Checksum.py
An example of these processors in action can been seen at https://github.com/autopkg/n8felton-recipes/blob/master/Weka/Weka.download.recipe
The text was updated successfully, but these errors were encountered: