Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Remove dependency to ext/ctype #96

Open
Hywan opened this issue Nov 12, 2018 · 4 comments
Open

Remove dependency to ext/ctype #96

Hywan opened this issue Nov 12, 2018 · 4 comments

Comments

@Hywan
Copy link
Member

Hywan commented Nov 12, 2018

It has been noted in #93 (comment) that hoa/compiler depends ext/ctype just because of a single call to ctype_digit in a non-critical path. I think it's a good idea to remove this dependency :-).

@unkind
Copy link

unkind commented Nov 13, 2018

Is it worth it? This extension is built-in by default, unless you disabled it on purpose: https://secure.php.net/manual/en/ctype.installation.php.

composer.json should require it, though.

@Hywan
Copy link
Member Author

Hywan commented Dec 5, 2018

We only use it once, and for a minor feature. It should be easy to write a workaround.

@Majkl578
Copy link

Majkl578 commented Jan 7, 2019

Doesn't make sense to me - ctype is implicit extension.

@flip111
Copy link

flip111 commented Jan 25, 2019

Keep extension since it comes with default php installation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants