This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Remove $nodeId from Token rule definition. #86

Open

SerafimArts opened this issue Aug 15, 2018 · 1 comment

Contributor

SerafimArts commented Aug 15, 2018

The third argument to the Token rule is not needed and is not required at runtime or for some other things. We can get rid of it.

new Token($id, $name, $nodeId, $unificationId, $kept);
//                    ^^^^^^^ - excess

SerafimArts mentioned this issue

Some questions about the structure of rules #85

Closed

flip111 commented Jan 25, 2019 •

edited

Loading

I read the code, and right now, I found no useful case where the $nodeId is used in the constructor. It is always set to null. I guess we can remove it!

Should be easy to fix this. Suggest adding issues to

https://up-for-grabs.net/#/

https://github.com/MunGell/awesome-for-beginners#php

https://www.firsttimersonly.com/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.