Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming Webhook must be nullable #318

Open
BenDenger opened this issue Aug 21, 2019 · 1 comment · Fixed by #341
Open

Incoming Webhook must be nullable #318

BenDenger opened this issue Aug 21, 2019 · 1 comment · Fixed by #341
Labels
bug Something isn't working

Comments

@BenDenger
Copy link
Collaborator

Currently, the incomingWebhook property of our Team-object is not nullable.
That causes that the user/developer has to set the incoming_webhook for his bot, otherwise it causes an error and the installation fails.

Expected Behavior

The incoming webhook property should be nullable, so the incoming_webhook is not necessary.

Current Behavior

it is necessary

Possible Solution

make the property nullable

Steps to Reproduce

install the bot, without setting the incoming webhook

@BenDenger BenDenger added the bug Something isn't working label Aug 21, 2019
@BenDenger BenDenger reopened this Oct 30, 2019
@BenDenger
Copy link
Collaborator Author

For some reason its not nullable anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant