Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version command #59

Open
ericmarkmartin opened this issue Sep 18, 2016 · 6 comments
Open

Version command #59

ericmarkmartin opened this issue Sep 18, 2016 · 6 comments
Assignees
Milestone

Comments

@ericmarkmartin
Copy link
Contributor

For the sake of debugging and compliance with CLI standards, a version command of some sort should be included in the shpotify API.

Possible ideas for the command syntax (multiple different syntaxes can be used):

  • spotify -V
  • spotify -v
  • spotify --version
  • spotify version
@hnarayanan hnarayanan added this to the 1.3 milestone Sep 18, 2016
@tpritc
Copy link

tpritc commented Sep 18, 2016

I like spotify -v and spotify --version.

@hnarayanan
Copy link
Owner

Agree with @tpritc.

@ericmarkmartin
Copy link
Contributor Author

ericmarkmartin commented Sep 18, 2016

I also agree with @tpritc: they are the most standard and thus the most predictable.

@ericmarkmartin
Copy link
Contributor Author

ericmarkmartin commented Sep 23, 2016

Essentially I'm debating whether to go with the simple version output (like Python):

$ python --version
Python 3.4.3

Or something with a license and other info:

$ bash --version
GNU bash, version 4.3.46(1)-release (x86_64-apple-darwin14.5.0)
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

I'm probably overthinking this, but I would rather just get it right the first time. What do you guys think about this?

In the meantime I'll just post a PR with a simple version command, and if that's what you guys want, we can merge and be done with this issue.

@ericmarkmartin
Copy link
Contributor Author

Added PR #64

@hnarayanan
Copy link
Owner

Still reeling from the last flurry of commits and the release. Will get to this in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants