Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-by-one error on vol command #145

Open
ghost opened this issue Oct 22, 2020 · 4 comments
Open

Off-by-one error on vol command #145

ghost opened this issue Oct 22, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 22, 2020

Screen Shot 2020-10-22 at 00 21 06

"spotify vol show" and "spotify vol up/down" results are off by one

@hnarayanan
Copy link
Owner

I honestly do not know how to fix this. This has been an error since the beginning of this project.

@davidem
Copy link

davidem commented Sep 29, 2021

It's a funny applescript thingy. No idea why... but if I set the volume using a direct api call it is no longer off-by-one.

image

(never mind the white output, thats for quick debugging only)

If needed I'll update it and create PR.

@hnarayanan
Copy link
Owner

It is not needed but it will be appreciated. 😸 If it is a small change, please do raise a PR.

@davidem
Copy link

davidem commented Sep 29, 2021

Ah, I now see there already is a 'dirty' +1 fix 😎, waiting to be merged... #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants