Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions for flake8 script to test the code linting #719

Closed
ninetteadhikari opened this issue Nov 2, 2020 · 4 comments
Closed

Comments

@ninetteadhikari
Copy link
Member

No description provided.

@ninetteadhikari ninetteadhikari changed the title flake8 script to test the code linting Update Github actions for flake8 script to test the code linting Nov 2, 2020
@felixfaisal
Copy link

Can i know more about this issue, as i checked the actions file and tests for flake8 are already present @ninetteadhikari

@ninetteadhikari
Copy link
Member Author

hey @felixfaisal thanks so much for reaching out! yes you right I will need to look into this issue change it.
We have some small errors you can help fix if you are interested: #692, #648
Have you been able to setup Activity locally? Let me know if you need any help:)

@felixfaisal
Copy link

@ninetteadhikari Sorry for replying late, I think I didn't get the email notification. I'll setup it up locally and look into them. Thanks!!

@TAnas0
Copy link
Collaborator

TAnas0 commented Sep 6, 2021

The Flake8 linting process is done in the Build and test Github action: https://github.com/hikaya-io/activity/blob/develop/.github/workflows/activity_ci_cd.yml#L36
It only raises errors on a subset of linting rules E9,F63,F7,F82, which can be matched against in Flake8 error code

@TAnas0 TAnas0 closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants