Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hifis.gitlab role #241

Merged
merged 1 commit into from
May 23, 2024
Merged

Add hifis.gitlab role #241

merged 1 commit into from
May 23, 2024

Conversation

Normo
Copy link
Member

@Normo Normo commented May 21, 2024 •
edited

@Normo Normo added the gitlab Related to hifis.gitlab role label May 21, 2024
@Normo Normo self-assigned this May 21, 2024
@Normo Normo force-pushed the 240-add-hifis.gitlab-role branch 5 times, most recently from 276807e to cc4655f Compare May 22, 2024 13:10
@Normo Normo marked this pull request as ready for review May 22, 2024 13:25
@Normo Normo requested a review from a team as a code owner May 22, 2024 13:25
@Normo Normo added this to the v4.2.0 milestone May 22, 2024
@Normo Normo requested a review from tobiashuste May 22, 2024 13:25
@Normo Normo force-pushed the 240-add-hifis.gitlab-role branch from cc4655f to 7924ee0 Compare May 22, 2024 13:25
@Normo Normo changed the title WIP: Add hifis.gitlab role Add hifis.gitlab role May 22, 2024
tobiashuste
tobiashuste requested changes May 23, 2024
View reviewed changes
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. 👍

Only the top level README needs a little update.

@Normo
Add hifis.gitlab role
e961e62 
Signed-off-by: Norman Ziegner <[email protected]>
@Normo Normo force-pushed the 240-add-hifis.gitlab-role branch from 7924ee0 to e961e62 Compare May 23, 2024 08:26
@Normo Normo merged commit 4571797 into hifis-net:main May 23, 2024
10 checks passed
@Normo Normo deleted the 240-add-hifis.gitlab-role branch May 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiashuste tobiashuste tobiashuste requested changes

Assignees

@Normo Normo

Labels
gitlab Related to hifis.gitlab role
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.

Include hifis.gitlab role into collection
2 participants
@Normo @tobiashuste