Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace pureCommentPlugin with __NO_SIDE_EFFECTS__ annotation #472

Closed
hi-ogawa opened this issue Aug 6, 2023 · 1 comment · Fixed by #476
Closed

refactor: replace pureCommentPlugin with __NO_SIDE_EFFECTS__ annotation #472

hi-ogawa opened this issue Aug 6, 2023 · 1 comment · Fixed by #476

Comments

@hi-ogawa
Copy link
Owner

hi-ogawa commented Aug 6, 2023

Just discovered __NO_SIDE_EFFECTS__ is being introduced in rollup then later esbuild followed up

This can replace my super ad-hoc pureCommentPlugin:

ytsub-v3/remix.config.js

Lines 32 to 33 in 9d67042

// tree-shake `export const loader = makeLoader(...)` from client bundle
function pureCommentPlugin() {

@hi-ogawa hi-ogawa changed the title refactor: replace pureCommentPlugin with __NO_SIDE_EFFECTS__ annotation? refactor: replace pureCommentPlugin with __NO_SIDE_EFFECTS__ annotation Aug 6, 2023
@hi-ogawa
Copy link
Owner Author

Or we can go with another workaround and pureCommentPlugin will be irrelevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant