Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve masked emoji appearence #473

Open
sotha1 opened this issue Nov 7, 2023 · 10 comments
Open

improve masked emoji appearence #473

sotha1 opened this issue Nov 7, 2023 · 10 comments

Comments

@sotha1
Copy link

sotha1 commented Nov 7, 2023

I think the masked emoji can be confused with a smile or something else, it's a bit subjective, but here's my suggestion:

here's the original:
1F637_color
and my one:
1F637_color (cópia)

i know that it's a weird drawing but that's a exemple of the emoji should look on my idea

@b-g
Copy link
Member

b-g commented Nov 8, 2023

Hi @sotha1, many thanks! Good call, yes your suggestions would definitely improve it, especially as other OpenMojis with masks eg. https://openmoji.org/library/emoji-E0AC-200D-2642-FE0F/ have a style like the one you suggested.

Could you go ahead and grab the src file and edit/improve it? :)

@sotha1
Copy link
Author

sotha1 commented Nov 8, 2023

do you mean 'svg' with 'src'? if yep, of course, its on my way

@sotha1
Copy link
Author

sotha1 commented Nov 8, 2023

here's it: (optimized svg)
1F637

@b-g
Copy link
Member

b-g commented Nov 10, 2023

Great! Here is some hyper specific feedback :) If we re-do the OpenMoji it would be nice to be really 100%. I hope you don't mind!

  • the upper mask line (around the noise) could be done with fewer points e.g. straight lines (only 3 points) or a single curve (arc)
  • it would be better to redo the white lines using a polygon to avoid the tiny yellow area
  • it would be better to align the lower white edge to the center of the black line

2023-11-10 at 14 05

OK? Please make sure to submit then the final file tested (-> https://openmoji-tester.glitch.me/) and a src svg which has the grid layer in it.

@sotha1
Copy link
Author

sotha1 commented Nov 10, 2023

here is it. i tried to upgrade this points that you mentioned, and a little tweak too:
1F637
i don't know if you will like the detail: i remove the white line that you mentioned at the second point.
if you prefer, i would add the white line again, before i test it.

@b-g
Copy link
Member

b-g commented Nov 13, 2023

Hi @sotha1, great improvements! No further comments :) Either do a pull request or upload the src file in this chat, please test the file beforehand with the https://openmoji-tester.glitch.me/. Cheers!

@sotha1
Copy link
Author

sotha1 commented Nov 13, 2023

Hi @sotha1, great improvements! No further comments :) Either do a pull request or upload the src file in this chat, please test the file beforehand with the https://openmoji-tester.glitch.me/. Cheers!

hey, i found these errors:

Captura de tela de 2023-11-13 13-02-30
Captura de tela de 2023-11-13 13-02-47

do you know how to fix they?

@b-g
Copy link
Member

b-g commented Nov 14, 2023

@sotha1 this is hard to debug from remote :) Hence please use the original source file and copy your changes over. Please see also https://openmoji.org/styleguide/ and especially https://openmoji.org/styleguide/#submission I hope this helps.

@sotha1
Copy link
Author

sotha1 commented Nov 15, 2023

sorry, i did resolve 2 of the 3 problems, and my last is this:
Captura de tela de 2023-11-15 10-22-01

it's the only one that i doesn't got to resolve. if you can give me the trick, i will thank you so :D

@b-g
Copy link
Member

b-g commented Nov 15, 2023

Open the SVG and check that all elements e.g. rect, line, circle ... don't have any style attribute e.g. remove all style="some css code" the problem is that svg elements can be styled with dedicated attributes but also with inline css code encapsulated in a style attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants