Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U.S. subdivision flags #467

Open
maxterry opened this issue Sep 13, 2023 · 16 comments
Open

U.S. subdivision flags #467

maxterry opened this issue Sep 13, 2023 · 16 comments

Comments

@maxterry
Copy link

maxterry commented Sep 13, 2023

As with other emoji sets, looks like only England, Scotland, and Wales are currently included as subdivision flags.

State and territory flags for the U.S. are defined and possible, just not implemented: https://blog.emojipedia.org/us-state-flag-emojis-now-possible

Would be cool to get them included here along with the fun extra flags.

Related to #416

@Kirylchyk
Copy link
Contributor

hey @maxterry, I picked up and started to work on this enhancement. #489 was merged to add Washington DC flag emoji. I am aware of the following flags https://en.wikipedia.org/wiki/Category:United_States_state_flags and planning to add flags at the reasonable pace. Do you have any order preferences? Thank you

@xavizardKnight
Copy link
Contributor

@Kirylchyk @alexcochran Heyas! I want to start advancing with the US subdivision flags, now that the subdivision flags of Spain are done, and I've seen that both of you have contributed some recently. Have you done any more advancements on other flags? Can I continue on working on the remaining flags?

@Kirylchyk
Copy link
Contributor

hey @xavizardKnight that's awesome! Indeed, i'm working on some more emoji. Lets split

@maxterry
Copy link
Author

maxterry commented Apr 9, 2024

Nice to see some momentum on this! Would be great to work toward a complete set of U.S. subdivision flags eventually, no preference from my side on order/priority to get there.

@xavizardKnight
Copy link
Contributor

hey @xavizardKnight that's awesome! Indeed, i'm working on some more emoji. Lets split

Yeah! If you started some, give me the list of those you haven't started yet. Or let's split the list 50/50 and start working from there, as you prefer.

Nice to see some momentum on this! Would be great to work toward a complete set of U.S. subdivision flags eventually, no preference from my side on order/priority to get there.

We can try to aim and see if we can complete all the US subdivision flags before the next OpenMoji release; there are quite a few flags, and some of them are pretty complex, but I think we can manage to pull it off.
Don't know when it will be the next release, but probably by the end of this year.

@xavizardKnight
Copy link
Contributor

Also, I've realised that the recently added Colorado flag has no grid layer in its source file. Technically, it does have a grid layer, but it's hidden. This doesn't seem to affect the outputs, but it looks weird in comparison with the rest of the flags when viewing the thumbnails of the folder. Was this intentional?

2024-04-09_19-43

@Kirylchyk
Copy link
Contributor

let's split the list 50/50

@alexcochran
Copy link

alexcochran commented Apr 9, 2024 via email

@xavizardKnight
Copy link
Contributor

The hidden grid was not intentional; i just don't think I noticed it was different than the others during development. I'd be happy to work on some more of the US states collaboratively.

Don't worry. I'll do now a quick PR readding the grid, it's a quick fix.

let's split the list 50/50

We can split the remaining list in 3 parts; then all 3 we can contribute.

@Kirylchyk
Copy link
Contributor

agree, i have no preferences.

By now, i'm working on:
[Flags of Alabama](https://en.wikipedia.org/wiki/Category:Flags_of_Alabama)‎ (1 C, 1 P)
[Flags of Utah](https://en.wikipedia.org/wiki/Category:Flags_of_Utah)‎ (1 C, 1 P)

And then we can split, what is left

@Kirylchyk
Copy link
Contributor

@alexcochran @xavizardKnight fyi opened PR for Alabama flag ->

Reference 1: #497
Reference 2: https://en.wikipedia.org/wiki/Flag_of_Alabama

Thx!

@xavizardKnight
Copy link
Contributor

alexcochran xavizardKnight fyi opened PR for Alabama flag

Nice!

I've been starting to experiment with the Hawaii, Arizona, Washington (state, not DC), Ohio and Montana flags. They look a bit tricky, and I like challenges, so I'm playing with them to see what I can do.

We really should create a list or something so we can see who does what and what remains…

Also, it would be nice to not create one PR per flag; let's make all of us one PR per person with all the US subdivision flags when we finish them all. Otherwise, there will be a lot of small PRs.

@Kirylchyk
Copy link
Contributor

i would prefer to keep each flag per one separate commit

@b-g
Copy link
Member

b-g commented Apr 15, 2024

Super that the two of you starting to tackle this! Great!

Small note: I would prefer less PRs than for every single flag a dedicated PR. Generating and checking is quite some work. Sorry! OpenMoji is quite heavy ...

@Kirylchyk
Copy link
Contributor

Gotcha, i'll try to combine several flags in one PR. I would prefer to work on my own branch at my pace. Thank you

@b-g
Copy link
Member

b-g commented Apr 15, 2024

@Kirylchyk Great! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants