-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U.S. subdivision flags #467
Comments
hey @maxterry, I picked up and started to work on this enhancement. #489 was merged to add Washington DC flag emoji. I am aware of the following flags https://en.wikipedia.org/wiki/Category:United_States_state_flags and planning to add flags at the reasonable pace. Do you have any order preferences? Thank you |
@Kirylchyk @alexcochran Heyas! I want to start advancing with the US subdivision flags, now that the subdivision flags of Spain are done, and I've seen that both of you have contributed some recently. Have you done any more advancements on other flags? Can I continue on working on the remaining flags? |
hey @xavizardKnight that's awesome! Indeed, i'm working on some more emoji. Lets split |
Nice to see some momentum on this! Would be great to work toward a complete set of U.S. subdivision flags eventually, no preference from my side on order/priority to get there. |
Yeah! If you started some, give me the list of those you haven't started yet. Or let's split the list 50/50 and start working from there, as you prefer.
We can try to aim and see if we can complete all the US subdivision flags before the next OpenMoji release; there are quite a few flags, and some of them are pretty complex, but I think we can manage to pull it off. |
Also, I've realised that the recently added Colorado flag has no grid layer in its source file. Technically, it does have a grid layer, but it's hidden. This doesn't seem to affect the outputs, but it looks weird in comparison with the rest of the flags when viewing the thumbnails of the folder. Was this intentional? |
let's split the list 50/50 |
The hidden grid was not intentional; i just don't think I noticed it was
different than the others during development.
I'd be happy to work on some more of the US states collaboratively.
…On Tue, Apr 9, 2024, 14:15 Xavier Martínez ***@***.***> wrote:
Also, I've realised that the recently added Colorado flag has no grid
layer in its source file. Technically, it does have a grid layer, but it's
hidden. This doesn't seem to affect the outputs, but it looks weird in
comparison with the rest of the flags when viewing the thumbnails of the
folder. Was this intentional?
2024-04-09_19-43.png (view on web)
<https://github.com/hfg-gmuend/openmoji/assets/35200790/0f386fd3-182b-4f08-8f4d-f197759fec74>
—
Reply to this email directly, view it on GitHub
<#467 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNOHOTHLZXU62DHEITDFA3Y4QV45AVCNFSM6AAAAAA4XETZ7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVHAYTQMJSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Don't worry. I'll do now a quick PR readding the grid, it's a quick fix.
We can split the remaining list in 3 parts; then all 3 we can contribute. |
agree, i have no preferences. By now, i'm working on: And then we can split, what is left |
@alexcochran @xavizardKnight fyi opened PR for Alabama flag -> Reference 1: #497 Thx! |
Nice! I've been starting to experiment with the Hawaii, Arizona, Washington (state, not DC), Ohio and Montana flags. They look a bit tricky, and I like challenges, so I'm playing with them to see what I can do. We really should create a list or something so we can see who does what and what remains… Also, it would be nice to not create one PR per flag; let's make all of us one PR per person with all the US subdivision flags when we finish them all. Otherwise, there will be a lot of small PRs. |
i would prefer to keep each flag per one separate commit |
Super that the two of you starting to tackle this! Great! Small note: I would prefer less PRs than for every single flag a dedicated PR. Generating and checking is quite some work. Sorry! OpenMoji is quite heavy ... |
Gotcha, i'll try to combine several flags in one PR. I would prefer to work on my own branch at my pace. Thank you |
@Kirylchyk Great! Many thanks! |
As with other emoji sets, looks like only England, Scotland, and Wales are currently included as subdivision flags.
State and territory flags for the U.S. are defined and possible, just not implemented: https://blog.emojipedia.org/us-state-flag-emojis-now-possible
Would be cool to get them included here along with the fun extra flags.
Related to #416
The text was updated successfully, but these errors were encountered: