Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for deps.edn-only projects #112

Closed
wants to merge 13 commits into from

Conversation

cap10morgan
Copy link

Closes #75

This detects when projects only have a deps.edn file and uses the Clojure CLI tools to build and run the app instead of lein. I have tested it with one of my deps.edn apps and it is working there.

@cap10morgan cap10morgan requested a review from a team as a code owner November 22, 2021 18:01
@cap10morgan
Copy link
Author

Should I point the tests at this fork for now? They pass when I do that locally.

@cap10morgan
Copy link
Author

@heroku/languages any chance this can get reviewed if I rebase on main?

@cap10morgan
Copy link
Author

@edmorley @schneems @lillianzhang331 Sorry for pinging you randomly but I saw that you reviewed and merged a few recent PRs. Any chance of getting this one reviewed if I rebase on latest main?

@Malax
Copy link
Member

Malax commented Apr 6, 2022

Hey @cap10morgan! Sorry for the long delay on this, my apologies! This is a IMO great addition to the buildpack, thanks for working on this!

I won't have time to review this immediately, but I should have some time next week. Feel free to ping me directly in the future so we can get this over the finish line! :)

@cap10morgan
Copy link
Author

Thanks @Malax! I'll get this mergeable with main again then.

@cap10morgan
Copy link
Author

@Malax Ready for review whenever you get a moment (and thanks again!)

@Malax
Copy link
Member

Malax commented Apr 12, 2022

@cap10morgan I've just pulled your branch into this repo so that CI can run (we disable CI for external PR's to avoid leaking credentials). As you can see, it went through without a hitch. I'll continue with a code review as the next step! :)

@cap10morgan
Copy link
Author

@Malax any updates on this? Let me know if there is anything else I can do to move this forward on my end. Thanks!

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm about to enable review reminder for team-alias reviews, so I'm switching any reviews that need language-owner review to the owner directly, to prevent reminders the rest of the team can't action)

@edmorley edmorley requested a review from Malax April 26, 2022 08:39
@skydread1
Copy link

Hi, any updates on this?
I will really like to see this feature available as we use deps.edn only as well.

@versality
Copy link

+1
We're also building a deps.edn only project and considering to use Heroku. Would be great to have it merged.

@cap10morgan
Copy link
Author

I no longer use Heroku and wouldn't even be willing to resolve the conflicts in here at this point. I recommend seeking out hosting platforms that give a shit instead.

@cap10morgan cap10morgan deleted the feature/tools-deps-cli branch November 20, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI and tools.deps support
5 participants