New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid values.schema.json passes lint #12994
Comments
Are you able to provide a minimal example we can use to reproduce? I using a default chart generated using |
Hello, indeed I forgot the example 🤦 {
"type": "object",
"required": [
"image"
],
"properties": {
"image": {
"type": "object",
"required": [
"repository",
"pullPolicy"
],
"properties": {
"repository": {
"type": "string",
"pattern": "^([-_/.a-z0-9]+)$"
},
"pullPolicy": {
"type": "string",
"pattern": "^(Always|Never|IfNotPresent)$"
}
}}
}
}
} You can see the double curly brace after
We found out we broke our json thanks to
I think we can expect lint+template to fail like package does 😄 For example, our CI lints on dev branches but packages only on release/pre-release Thanks for your help 🙏 |
I managed to reproduce the error as well. This is a valid issue |
I've marked this as a feature, with the presumption that If that presumption is wrong (and helm is validating Either way, PR is welcome please. |
Hello,
We have helm 3.14.4
We have built a
values.schema.json
which works very well, this is super useful! However, recently, we introduced a bug (double curly brace) in it which makes the json invalid. Helm is happy with it:However, the json is invalid:
This makes
helm lint
/helm template
misleading as they report valid values, whereas it's not.When I fix the jsonschema, I get failures that were hidden by the wrong status before:
Could you check please?
The text was updated successfully, but these errors were encountered: