-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot tests always pass before --update
is run
#246
Comments
--update
is run the first time
--update
is run the first time--update
is run
An example of where this is a problem
Changing the |
Would you be open to accepting pull requests for this issue? |
I'm seeing the same issue. Very frustrating when I'm doing major refactors. It can also surface when there's a critical issue with your templates, and helm unit thinks nothing was generated, then you fix the critical issue, and helm unit now thinks what once was empty is now existing, so it just auto-updates the snapshot. |
(version:
0.3.6
)When adding a new snapshot test, the tests always seem to pass if no snapshot has been created yet.
E.g. if I add a test case like this:
running
helm unittest ...
results in a pass.So if I change something, e.g.:
the tests still pass.
It's only after I run with
-u
, and a snapshot is generated, that I can get a test failure.It seems like a fairly serious bug, as you can get things into production thinking you've not changed your snapshots, but really you have.
Probably the match snapshot func should always fail if no snapshot is found.
The text was updated successfully, but these errors were encountered: